From aae26ee33de912aa0a5193a3d9d86ae5d4856723 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Wed, 18 Sep 2024 12:34:10 +0200 Subject: [PATCH] go: Fix tasks when running tests/benchs in packages (#17998) Turns out that #17645 reintroduced another regression and didn't catch all the regressions in #17108. Releases Notes: - Fixed Go tasks not working properly when running tests or benchmarks in subfolders/packages. Co-authored-by: Piotr --- crates/languages/src/go.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/languages/src/go.rs b/crates/languages/src/go.rs index 2ddf779681..a103c4783c 100644 --- a/crates/languages/src/go.rs +++ b/crates/languages/src/go.rs @@ -519,7 +519,6 @@ impl ContextProvider for GoContextProvider { command: "go".into(), args: vec![ "test".into(), - GO_PACKAGE_TASK_VARIABLE.template_value(), "-run".into(), format!("^{}\\$", VariableName::Symbol.template_value(),), ], @@ -530,7 +529,7 @@ impl ContextProvider for GoContextProvider { TaskTemplate { label: format!("go test {}", GO_PACKAGE_TASK_VARIABLE.template_value()), command: "go".into(), - args: vec!["test".into(), GO_PACKAGE_TASK_VARIABLE.template_value()], + args: vec!["test".into()], cwd: package_cwd.clone(), ..TaskTemplate::default() }, @@ -572,7 +571,6 @@ impl ContextProvider for GoContextProvider { command: "go".into(), args: vec![ "test".into(), - GO_PACKAGE_TASK_VARIABLE.template_value(), "-benchmem".into(), "-run=^$".into(), "-bench".into(),