Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix panic when diagnostics first opens (#28935)

Browse source 
Closes #ISSUE

Release Notes:

- N/A
This commit is contained in:
Conrad Irwin 2025-04-16 21:57:42 -06:00 • committed by GitHub
parent a7a7335da4
commit ad25cd09b6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/diagnostics/src/diagnostics.rs
View file

@ -46,6 +46,7 @@ use workspace::{
actions!(diagnostics, [Deploy, ToggleWarnings]); actions!(diagnostics, [Deploy, ToggleWarnings]);
#[derive(Default)]
pub(crate) struct IncludeWarnings(bool); pub(crate) struct IncludeWarnings(bool);
impl Global for IncludeWarnings {} impl Global for IncludeWarnings {}

6
crates/diagnostics/src/items.rs
View file

@ -95,9 +95,9 @@ impl Render for DiagnosticIndicator {
.on_click(cx.listener(|this, _, window, cx| { .on_click(cx.listener(|this, _, window, cx| {
if let Some(workspace) = this.workspace.upgrade() { if let Some(workspace) = this.workspace.upgrade() {
if this.summary.error_count == 0 && this.summary.warning_count > 0 { if this.summary.error_count == 0 && this.summary.warning_count > 0 {
cx.update_global(|show_warnings: &mut IncludeWarnings, _| { cx.update_default_global(
show_warnings.0 = true |show_warnings: &mut IncludeWarnings, _| show_warnings.0 = true,
}); );
} }
workspace.update(cx, |workspace, cx| { workspace.update(cx, |workspace, cx| {
ProjectDiagnosticsEditor::deploy( ProjectDiagnosticsEditor::deploy(