Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove all debug logging from inlay hint hover implementation

Browse source
This commit is contained in:
Richard Feldman 2025-07-10 17:42:34 -04:00
parent 509375c83c
commit b1cd20a435
No known key found for this signature in database
2 changed files with 0 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/editor/src/element.rs
View file

@ -1222,7 +1222,6 @@ impl EditorElement {
// Don't trigger hover popover if mouse is hovering over context menu // Don't trigger hover popover if mouse is hovering over context menu
if text_hovered { if text_hovered {
eprintln!("mouse_moved: text_hovered=true, calling update_hovered_link");
editor.update_hovered_link( editor.update_hovered_link(
point_for_position, point_for_position,
&position_map.snapshot, &position_map.snapshot,
@ -1236,11 +1235,9 @@ impl EditorElement {
.snapshot .snapshot
.buffer_snapshot .buffer_snapshot
.anchor_before(point.to_offset(&position_map.snapshot, Bias::Left)); .anchor_before(point.to_offset(&position_map.snapshot, Bias::Left));
eprintln!("mouse_moved: Valid text position, calling hover_at with anchor");
hover_at(editor, Some(anchor), window, cx); hover_at(editor, Some(anchor), window, cx);
Self::update_visible_cursor(editor, point, position_map, window, cx); Self::update_visible_cursor(editor, point, position_map, window, cx);
} else { } else {
eprintln!("mouse_moved: Invalid position (inlay?), NOT calling hover_at");
// Don't call hover_at with None when we're over an inlay // Don't call hover_at with None when we're over an inlay
// The inlay hover is already handled by update_hovered_link // The inlay hover is already handled by update_hovered_link
} }

20
crates/editor/src/hover_popover.rs
View file

@ -48,10 +48,6 @@ pub fn hover_at(
window: &mut Window, window: &mut Window,
cx: &mut Context<Editor>, cx: &mut Context<Editor>,
) { ) {
eprintln!(
"hover_at called with anchor: {}",
if anchor.is_some() { "Some" } else { "None" }
);
if EditorSettings::get_global(cx).hover_popover_enabled { if EditorSettings::get_global(cx).hover_popover_enabled {
if show_keyboard_hover(editor, window, cx) { if show_keyboard_hover(editor, window, cx) {
return; return;
@ -216,7 +212,6 @@ pub fn hover_at_inlay(
/// Triggered by the `Hover` action when the cursor is not over a symbol or when the /// Triggered by the `Hover` action when the cursor is not over a symbol or when the
/// selections changed. /// selections changed.
pub fn hide_hover(editor: &mut Editor, cx: &mut Context<Editor>) -> bool { pub fn hide_hover(editor: &mut Editor, cx: &mut Context<Editor>) -> bool {
eprintln!("hide_hover called");
let info_popovers = editor.hover_state.info_popovers.drain(..); let info_popovers = editor.hover_state.info_popovers.drain(..);
let diagnostics_popover = editor.hover_state.diagnostic_popover.take(); let diagnostics_popover = editor.hover_state.diagnostic_popover.take();
let did_hide = info_popovers.count() > 0 || diagnostics_popover.is_some(); let did_hide = info_popovers.count() > 0 || diagnostics_popover.is_some();
@ -791,12 +786,6 @@ impl HoverState {
window: &mut Window, window: &mut Window,
cx: &mut Context<Editor>, cx: &mut Context<Editor>,
) -> Option<(DisplayPoint, Vec<AnyElement>)> { ) -> Option<(DisplayPoint, Vec<AnyElement>)> {
let visible = self.visible();
eprintln!(
"HoverState::render - visible: {}, info_popovers: {}",
visible,
self.info_popovers.len()
);
// If there is a diagnostic, position the popovers based on that. // If there is a diagnostic, position the popovers based on that.
// Otherwise use the start of the hover range // Otherwise use the start of the hover range
let anchor = self let anchor = self
@ -820,18 +809,9 @@ impl HoverState {
}) })
})?; })?;
let point = anchor.to_display_point(&snapshot.display_snapshot); let point = anchor.to_display_point(&snapshot.display_snapshot);
eprintln!(
"HoverState::render - point: {:?}, visible_rows: {:?}",
point, visible_rows
);
// Don't render if the relevant point isn't on screen // Don't render if the relevant point isn't on screen
if !self.visible() || !visible_rows.contains(&point.row()) { if !self.visible() || !visible_rows.contains(&point.row()) {
eprintln!(
"HoverState::render - Not rendering: visible={}, point_in_range={}",
self.visible(),
visible_rows.contains(&point.row())
);
return None; return None;
} }