Fix profile menu hover flickering due to documentation asides (#29958)

Fixes https://github.com/zed-industries/zed/issues/29909 

🍐'd with @nathansobo 

Release Notes:

- N/A

---------

Co-authored-by: Nathan <nathan@zed.dev>

crates/agent/src/assistant_panel.rs

@@ -466,6 +466,7 @@ impl AssistantPanel {
                 thread_store.downgrade(),
                 context_store.downgrade(),
                 thread.clone(),
+                agent_panel_dock_position(cx),
                 window,
                 cx,
             )
@@ -795,6 +796,7 @@ impl AssistantPanel {
                 self.thread_store.downgrade(),
                 self.context_store.downgrade(),
                 thread,
+                agent_panel_dock_position(cx),
                 window,
                 cx,
             )
@@ -1003,6 +1005,7 @@ impl AssistantPanel {
                 self.thread_store.downgrade(),
                 self.context_store.downgrade(),
                 thread,
+                agent_panel_dock_position(cx),
                 window,
                 cx,
             )
@@ -1330,6 +1333,14 @@ impl Focusable for AssistantPanel {
     }
 }
 
+fn agent_panel_dock_position(cx: &App) -> DockPosition {
+    match AssistantSettings::get_global(cx).dock {
+        AssistantDockPosition::Left => DockPosition::Left,
+        AssistantDockPosition::Bottom => DockPosition::Bottom,
+        AssistantDockPosition::Right => DockPosition::Right,
+    }
+}
+
 impl EventEmitter<PanelEvent> for AssistantPanel {}
 
 impl Panel for AssistantPanel {
@@ -1338,18 +1349,18 @@ impl Panel for AssistantPanel {
     }
 
     fn position(&self, _window: &Window, cx: &App) -> DockPosition {
-        match AssistantSettings::get_global(cx).dock {
-            AssistantDockPosition::Left => DockPosition::Left,
-            AssistantDockPosition::Bottom => DockPosition::Bottom,
-            AssistantDockPosition::Right => DockPosition::Right,
-        }
+        agent_panel_dock_position(cx)
     }
 
-    fn position_is_valid(&self, _: DockPosition) -> bool {
-        true
+    fn position_is_valid(&self, position: DockPosition) -> bool {
+        position != DockPosition::Bottom
     }
 
     fn set_position(&mut self, position: DockPosition, _: &mut Window, cx: &mut Context<Self>) {
+        self.message_editor.update(cx, |message_editor, cx| {
+            message_editor.set_dock_position(position, cx);
+        });
+
         settings::update_settings_file::<AssistantSettings>(
             self.fs.clone(),
             cx,

crates/agent/src/message_editor.rs

@@ -35,8 +35,9 @@ use proto::Plan;
 use settings::Settings;
 use std::time::Duration;
 use theme::ThemeSettings;
-use ui::{Disclosure, KeyBinding, PopoverMenuHandle, Tooltip, prelude::*};
+use ui::{Disclosure, DocumentationSide, KeyBinding, PopoverMenuHandle, Tooltip, prelude::*};
 use util::{ResultExt as _, maybe};
+use workspace::dock::DockPosition;
 use workspace::{CollaboratorId, Workspace};
 use zed_llm_client::CompletionMode;
 
@@ -130,6 +131,14 @@ pub(crate) fn create_editor(
     editor
 }
 
+fn documentation_side(position: DockPosition) -> DocumentationSide {
+    match position {
+        DockPosition::Left => DocumentationSide::Right,
+        DockPosition::Bottom => DocumentationSide::Left,
+        DockPosition::Right => DocumentationSide::Left,
+    }
+}
+
 impl MessageEditor {
     pub fn new(
         fs: Arc<dyn Fs>,
@@ -140,6 +149,7 @@ impl MessageEditor {
         thread_store: WeakEntity<ThreadStore>,
         text_thread_store: WeakEntity<TextThreadStore>,
         thread: Entity<Thread>,
+        dock_position: DockPosition,
         window: &mut Window,
         cx: &mut Context<Self>,
     ) -> Self {
@@ -213,8 +223,15 @@ impl MessageEditor {
             model_selector,
             edits_expanded: false,
             editor_is_expanded: false,
-            profile_selector: cx
-                .new(|cx| ProfileSelector::new(fs, thread_store, editor.focus_handle(cx), cx)),
+            profile_selector: cx.new(|cx| {
+                ProfileSelector::new(
+                    fs,
+                    thread_store,
+                    editor.focus_handle(cx),
+                    documentation_side(dock_position),
+                    cx,
+                )
+            }),
             last_estimated_token_count: None,
             update_token_count_task: None,
             _subscriptions: subscriptions,
@@ -1253,6 +1270,12 @@ impl MessageEditor {
             .ok();
         }));
     }
+
+    pub fn set_dock_position(&mut self, position: DockPosition, cx: &mut Context<Self>) {
+        self.profile_selector.update(cx, |profile_selector, cx| {
+            profile_selector.set_documentation_side(documentation_side(position), cx)
+        });
+    }
 }
 
 pub fn extract_message_creases(
@@ -1426,6 +1449,7 @@ impl AgentPreview for MessageEditor {
                     thread_store.downgrade(),
                     text_thread_store.downgrade(),
                     thread,
+                    DockPosition::Left,
                     window,
                     cx,
                 )

crates/agent/src/profile_selector.rs

@@ -7,7 +7,10 @@ use fs::Fs;
 use gpui::{Action, Entity, FocusHandle, Subscription, WeakEntity, prelude::*};
 use language_model::LanguageModelRegistry;
 use settings::{Settings as _, SettingsStore, update_settings_file};
-use ui::{ContextMenu, ContextMenuEntry, PopoverMenu, PopoverMenuHandle, Tooltip, prelude::*};
+use ui::{
+    ContextMenu, ContextMenuEntry, DocumentationSide, PopoverMenu, PopoverMenuHandle, Tooltip,
+    prelude::*,
+};
 use util::ResultExt as _;
 
 use crate::{ManageProfiles, ThreadStore, ToggleProfileSelector};
@@ -19,6 +22,7 @@ pub struct ProfileSelector {
     menu_handle: PopoverMenuHandle<ContextMenu>,
     focus_handle: FocusHandle,
     _subscriptions: Vec<Subscription>,
+    documentation_side: DocumentationSide,
 }
 
 impl ProfileSelector {
@@ -26,6 +30,7 @@ impl ProfileSelector {
         fs: Arc<dyn Fs>,
         thread_store: WeakEntity<ThreadStore>,
         focus_handle: FocusHandle,
+        documentation_side: DocumentationSide,
         cx: &mut Context<Self>,
     ) -> Self {
         let settings_subscription = cx.observe_global::<SettingsStore>(move |this, cx| {
@@ -39,9 +44,15 @@ impl ProfileSelector {
             menu_handle: PopoverMenuHandle::default(),
             focus_handle,
             _subscriptions: vec![settings_subscription],
+            documentation_side,
         }
     }
 
+    pub fn set_documentation_side(&mut self, side: DocumentationSide, cx: &mut Context<Self>) {
+        self.documentation_side = side;
+        cx.notify();
+    }
+
     pub fn menu_handle(&self) -> PopoverMenuHandle<ContextMenu> {
         self.menu_handle.clone()
     }
@@ -101,7 +112,9 @@ impl ProfileSelector {
             .toggleable(IconPosition::End, profile_id == settings.default_profile);
 
         let entry = if let Some(doc_text) = documentation {
-            entry.documentation_aside(move |_| Label::new(doc_text).into_any_element())
+            entry.documentation_aside(self.documentation_side, move |_| {
+                Label::new(doc_text).into_any_element()
+            })
         } else {
             entry
         };
@@ -175,7 +188,11 @@ impl Render for ProfileSelector {
                     )
                 }
             })
-            .anchor(gpui::Corner::BottomRight)
+            .anchor(if self.documentation_side == DocumentationSide::Left {
+                gpui::Corner::BottomRight
+            } else {
+                gpui::Corner::BottomLeft
+            })
             .with_handle(self.menu_handle.clone())
             .menu(move |window, cx| {
                 Some(this.update(cx, |this, cx| this.build_context_menu(window, cx)))