From b5a7fb13c38838a3f0e4fd5fdc9b4c99df0c834e Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Thu, 13 Mar 2025 16:07:32 -0400 Subject: [PATCH] Remove github issue template for git beta and improve related CI (#26707) Remove the git beta issue template. Improve ci.yml `job_spec` so that changes like this will not require CI in the future. Improve ci.yml `job_spec` ensuring `output.run_license` exported for Cargo.lock. Release Notes: - N/A --------- Co-authored-by: Peter Tripp --- .../ISSUE_TEMPLATE/0_git_beta_bug_report.yml | 51 ------------------- .github/workflows/ci.yml | 8 ++- 2 files changed, 7 insertions(+), 52 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/0_git_beta_bug_report.yml diff --git a/.github/ISSUE_TEMPLATE/0_git_beta_bug_report.yml b/.github/ISSUE_TEMPLATE/0_git_beta_bug_report.yml deleted file mode 100644 index 199c182b70..0000000000 --- a/.github/ISSUE_TEMPLATE/0_git_beta_bug_report.yml +++ /dev/null @@ -1,51 +0,0 @@ -name: Git Beta -description: There is a bug related to new Git features in Zed -type: "Bug" -labels: [git] -title: "Git Beta: " -body: - - type: textarea - attributes: - label: Summary - description: Describe the bug with a one line summary, and provide detailed reproduction steps - value: | - - - - Steps to trigger the problem: - 1. - 2. - 3. - - Actual Behavior: - - Expected Behavior: - - validations: - required: true - - type: textarea - id: environment - attributes: - label: Zed Version and System Specs - description: 'Open Zed, and in the command palette select "zed: Copy System Specs Into Clipboard"' - placeholder: | - Output of "zed: Copy System Specs Into Clipboard" - validations: - required: true - - type: textarea - attributes: - label: If applicable, attach your `~/Library/Logs/Zed/Zed.log` file to this issue. - description: | - macOS: `~/Library/Logs/Zed/Zed.log` - Linux: `~/.local/share/zed/logs/Zed.log` or $XDG_DATA_HOME - If you only need the most recent lines, you can run the `zed: open log` command palette action to see the last 1000. - value: | -
Zed.log - - - ``` - - ``` -
- validations: - required: false diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 322198cdbd..326a585945 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,7 @@ jobs: if: github.repository_owner == 'zed-industries' outputs: run_tests: ${{ steps.filter.outputs.run_tests }} + run_license: ${{ steps.filter.outputs.run_license }} runs-on: - ubuntu-latest steps: @@ -47,7 +48,12 @@ jobs: git fetch origin "$GITHUB_BASE_REF" --depth=350 COMPARE_REV=$(git merge-base "origin/${GITHUB_BASE_REF}" HEAD) fi - if [[ $(git diff --name-only $COMPARE_REV ${{ github.sha }} | grep -v "^docs/") ]]; then + # Specify anything which should skip full CI in this regex: + # - docs/ + # - .github/ISSUE_TEMPLATE/ + # - .github/workflows/ (except .github/workflows/ci.yml) + SKIP_REGEX='^(docs/|\.github/(ISSUE_TEMPLATE|workflows/(?!ci)))' + if [[ $(git diff --name-only $COMPARE_REV ${{ github.sha }} | grep -vP "$SKIP_REGEX") ]]; then echo "run_tests=true" >> $GITHUB_OUTPUT else echo "run_tests=false" >> $GITHUB_OUTPUT