Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix jank in LSP debug log autoscroll (#22998)

Browse source 
Not sure why scroll was janky with `Autoscroll::newest()`, but this
appears to fix it. Probably better to conditionally do the autoscroll
requests anyway.

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-01-10 22:59:21 -07:00 • committed by GitHub
parent bbbd1e9902
commit b65dc8c566
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/editor/src/scroll/autoscroll.rs
View file

@ -32,10 +32,16 @@ impl Autoscroll {
pub fn focused() -> Self {
Self::Strategy(AutoscrollStrategy::Focused)
}
/// Scrolls so that the newest cursor is roughly an n-th line from the top.
pub fn top_relative(n: usize) -> Self {
Self::Strategy(AutoscrollStrategy::TopRelative(n))
}
/// Scrolls so that the newest cursor is at the bottom.
pub fn bottom() -> Self {
Self::Strategy(AutoscrollStrategy::Bottom)
}
}
#[derive(PartialEq, Eq, Default, Clone, Copy)]

7
crates/language_tools/src/lsp_log.rs
View file

@ -642,6 +642,8 @@ impl LspLogView {
log_view.editor.update(cx, |editor, cx| {
editor.set_read_only(false);
let last_point = editor.buffer().read(cx).len(cx);
let newest_cursor_is_at_end =
editor.selections.newest::<usize>(cx).start >= last_point;
editor.edit(
vec![
(last_point..last_point, entry.trim()),
@ -657,7 +659,10 @@ impl LspLogView {
cx,
);
}
editor.request_autoscroll(Autoscroll::fit(), cx);
if newest_cursor_is_at_end {
editor.request_autoscroll(Autoscroll::bottom(), cx);
}
editor.set_read_only(true);
});
}