Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

project search: Do not bail on search when a binary file is encountered (#23775)

Browse source 
Closes #ISSUE

Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz 2025-01-28 14:54:00 +01:00 • committed by GitHub
parent 7105f9c68c
commit b74a273934
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/project/src/worktree_store.rs
View file

@ -1026,9 +1026,10 @@ impl WorktreeStore {
{ {
// Before attempting to match the file content, throw away files that have invalid UTF-8 sequences early on; // Before attempting to match the file content, throw away files that have invalid UTF-8 sequences early on;
// That way we can still match files in a streaming fashion without having look at "obviously binary" files. // That way we can still match files in a streaming fashion without having look at "obviously binary" files.
return Err(anyhow!( log::debug!(
"Invalid UTF-8 sequence in file {abs_path:?} at byte position {starting_position}" "Invalid UTF-8 sequence in file {abs_path:?} at byte position {starting_position}"
)); );
continue;
} }
if query.detect(file).unwrap_or(false) { if query.detect(file).unwrap_or(false) {