Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpui: Fix shape_text split to support \r\n (#31022)

Browse source 
Release Notes:

- N/A

---

Today I check the shape_text result on Windows, I get:

<img width="409" alt="屏幕截图 2025-05-20 222908"
src="https://github.com/user-attachments/assets/3ee93911-3de1-4e01-9433-00c626fc2369"
/>

Here the `shape_text` split logic I think it should use `lines` method,
not `split('\n')`, the newline on Windows is `\r\n`.
This commit is contained in:
Jason Lee 2025-05-20 22:53:50 +08:00 • committed by GitHub
parent 0fa9f05313
commit b7d5e6480a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/gpui/src/text_system.rs
View file

@ -474,7 +474,7 @@ impl WindowTextSystem {
font_runs.clear(); font_runs.clear();
}; };
let mut split_lines = text.split('\n'); let mut split_lines = text.lines();
let mut processed = false; let mut processed = false;
if let Some(first_line) = split_lines.next() { if let Some(first_line) = split_lines.next() {