Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Show tooltip with item paths for recent project picker items (#8987)

Browse source 
Before

![empty-tooltip](https://github.com/zed-industries/zed/assets/5518/4a00158c-5ae1-4ef9-8686-d4c188a99050)

After

![output](https://github.com/zed-industries/zed/assets/5518/b30f8272-485d-40e1-989a-facd122e96c8)

Release Notes:

- Fixed empty tooltip for recent projects picker items
This commit is contained in:
Jason Lee 2024-03-07 23:35:48 +08:00 • committed by GitHub
parent d450fde1ed
commit bc7fb9f253
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crates/recent_projects/src/recent_projects.rs
View file

@ -325,14 +325,21 @@ impl PickerDelegate for RecentProjectsDelegate {
let highlighted_match = HighlightedMatchWithPaths { let highlighted_match = HighlightedMatchWithPaths {
match_label: HighlightedText::join(match_labels.into_iter().flatten(), ", "), match_label: HighlightedText::join(match_labels.into_iter().flatten(), ", "),
paths: if self.render_paths { paths } else { Vec::new() }, paths,
}; };
Some( Some(
ListItem::new(ix) ListItem::new(ix)
.inset(true) .inset(true)
.spacing(ListItemSpacing::Sparse) .spacing(ListItemSpacing::Sparse)
.selected(selected) .selected(selected)
.child(highlighted_match.clone().render(cx)) .child({
let mut highlighted = highlighted_match.clone();
if !self.render_paths {
highlighted.paths.clear();
}
highlighted.render(cx)
})
.when(!is_current_workspace, |el| { .when(!is_current_workspace, |el| {
let delete_button = div() let delete_button = div()
.child( .child(
@ -344,7 +351,7 @@ impl PickerDelegate for RecentProjectsDelegate {
this.delegate.delete_recent_project(ix, cx) this.delegate.delete_recent_project(ix, cx)
})) }))
.tooltip(|cx| Tooltip::text("Delete From Recent Projects...", cx)), .tooltip(|cx| Tooltip::text("Delete from Recent Projects...", cx)),
) )
.into_any_element(); .into_any_element();