assistant2: Make context pill names work like editor tabs (#22741)

Context pills for files will now only display the basename of the file.
If two files have the same base name, we will also show their parent
directories, mimicking the behavior of editor tabs.


https://github.com/user-attachments/assets/ee88ee3b-80ff-4115-9ff9-8fe4845a67d8

Note: The double `/` in the file picker is a known separate issue.

Release Notes:

- N/A

---------

Co-authored-by: Danilo <danilo@zed.dev>
Co-authored-by: Danilo Leal <daniloleal09@gmail.com>

crates/assistant2/src/ui/context_pill.rs

@@ -1,65 +1,148 @@
 use std::rc::Rc;
 
 use gpui::ClickEvent;
-use ui::{prelude::*, IconButtonShape};
+use ui::{prelude::*, IconButtonShape, Tooltip};
 
 use crate::context::{Context, ContextKind};
 
 #[derive(IntoElement)]
-pub struct ContextPill {
-    context: Context,
-    on_remove: Option<Rc<dyn Fn(&ClickEvent, &mut WindowContext)>>,
+pub enum ContextPill {
+    Added {
+        context: Context,
+        dupe_name: bool,
+        on_remove: Option<Rc<dyn Fn(&ClickEvent, &mut WindowContext)>>,
+    },
+    Suggested {
+        name: SharedString,
+        kind: ContextKind,
+        on_add: Rc<dyn Fn(&ClickEvent, &mut WindowContext)>,
+    },
 }
 
 impl ContextPill {
-    pub fn new(context: Context) -> Self {
-        Self {
+    pub fn new_added(
+        context: Context,
+        dupe_name: bool,
+        on_remove: Option<Rc<dyn Fn(&ClickEvent, &mut WindowContext)>>,
+    ) -> Self {
+        Self::Added {
             context,
-            on_remove: None,
+            dupe_name,
+            on_remove,
         }
     }
 
-    pub fn on_remove(mut self, on_remove: Rc<dyn Fn(&ClickEvent, &mut WindowContext)>) -> Self {
-        self.on_remove = Some(on_remove);
-        self
+    pub fn new_suggested(
+        name: SharedString,
+        kind: ContextKind,
+        on_add: Rc<dyn Fn(&ClickEvent, &mut WindowContext)>,
+    ) -> Self {
+        Self::Suggested { name, kind, on_add }
+    }
+
+    pub fn id(&self) -> ElementId {
+        match self {
+            Self::Added { context, .. } => {
+                ElementId::NamedInteger("context-pill".into(), context.id.0)
+            }
+            Self::Suggested { .. } => "suggested-context-pill".into(),
+        }
+    }
+
+    pub fn kind(&self) -> &ContextKind {
+        match self {
+            Self::Added { context, .. } => &context.kind,
+            Self::Suggested { kind, .. } => kind,
+        }
     }
 }
 
 impl RenderOnce for ContextPill {
     fn render(self, cx: &mut WindowContext) -> impl IntoElement {
-        let padding_right = if self.on_remove.is_some() {
-            px(2.)
-        } else {
-            px(4.)
-        };
-        let icon = match self.context.kind {
+        let icon = match &self.kind() {
             ContextKind::File => IconName::File,
             ContextKind::Directory => IconName::Folder,
             ContextKind::FetchedUrl => IconName::Globe,
             ContextKind::Thread => IconName::MessageCircle,
         };
 
-        h_flex()
-            .gap_1()
+        let color = cx.theme().colors();
+
+        let base_pill = h_flex()
+            .id(self.id())
             .pl_1()
-            .pr(padding_right)
             .pb(px(1.))
             .border_1()
-            .border_color(cx.theme().colors().border.opacity(0.5))
-            .bg(cx.theme().colors().element_background)
             .rounded_md()
-            .child(Icon::new(icon).size(IconSize::XSmall).color(Color::Muted))
-            .child(Label::new(self.context.name.clone()).size(LabelSize::Small))
-            .when_some(self.on_remove, |parent, on_remove| {
-                parent.child(
-                    IconButton::new(("remove", self.context.id.0), IconName::Close)
-                        .shape(IconButtonShape::Square)
-                        .icon_size(IconSize::XSmall)
-                        .on_click({
-                            let on_remove = on_remove.clone();
-                            move |event, cx| on_remove(event, cx)
-                        }),
+            .gap_1()
+            .child(Icon::new(icon).size(IconSize::XSmall).color(Color::Muted));
+
+        match &self {
+            ContextPill::Added {
+                context,
+                dupe_name,
+                on_remove,
+            } => base_pill
+                .bg(color.element_background)
+                .border_color(color.border.opacity(0.5))
+                .pr(if on_remove.is_some() { px(2.) } else { px(4.) })
+                .child(Label::new(context.name.clone()).size(LabelSize::Small))
+                .when_some(context.parent.as_ref(), |element, parent_name| {
+                    if *dupe_name {
+                        element.child(
+                            Label::new(parent_name.clone())
+                                .size(LabelSize::XSmall)
+                                .color(Color::Muted),
+                        )
+                    } else {
+                        element
+                    }
+                })
+                .when_some(context.tooltip.clone(), |element, tooltip| {
+                    element.tooltip(move |cx| Tooltip::text(tooltip.clone(), cx))
+                })
+                .when_some(on_remove.as_ref(), |element, on_remove| {
+                    element.child(
+                        IconButton::new(("remove", context.id.0), IconName::Close)
+                            .shape(IconButtonShape::Square)
+                            .icon_size(IconSize::XSmall)
+                            .tooltip(|cx| Tooltip::text("Remove Context", cx))
+                            .on_click({
+                                let on_remove = on_remove.clone();
+                                move |event, cx| on_remove(event, cx)
+                            }),
+                    )
+                }),
+            ContextPill::Suggested { name, kind, on_add } => base_pill
+                .cursor_pointer()
+                .pr_1()
+                .border_color(color.border_variant.opacity(0.5))
+                .hover(|style| style.bg(color.element_hover.opacity(0.5)))
+                .child(
+                    Label::new(name.clone())
+                        .size(LabelSize::Small)
+                        .color(Color::Muted),
                 )
-            })
+                .child(
+                    Label::new(match kind {
+                        ContextKind::File => "Open File",
+                        ContextKind::Thread | ContextKind::Directory | ContextKind::FetchedUrl => {
+                            "Active"
+                        }
+                    })
+                    .size(LabelSize::XSmall)
+                    .color(Color::Muted),
+                )
+                .child(
+                    Icon::new(IconName::Plus)
+                        .size(IconSize::XSmall)
+                        .into_any_element(),
+                )
+                .tooltip(|cx| Tooltip::with_meta("Suggested Context", None, "Click to add it", cx))
+                .on_click({
+                    let on_add = on_add.clone();
+                    move |event, cx| on_add(event, cx)
+                }),
+        }
     }
 }