Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix search/replace start of line anchor (#13920)

Browse source 
This is related to #9428 

I noticed that doing a search and replace for the beginning of a line
`^` results in the trailing line being included in the search. This
seems to be because of the way the range is generated for generating
matches being the up to the start of the trailing line rather than up to
the end of the last line.

I added a test and took a stab at fixing it but it is a bit yolo as this
is the first time I've seen this codebase.
This commit is contained in:
Andy Weiss 2024-07-09 14:39:24 -04:00 • committed by GitHub
parent 09e7b481b8
commit c093bc8aa8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 64 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/vim/test_data/test_replace_with_range_at_start.json Normal file
View file

@ -0,0 +1,16 @@
{"Put":{"state":"ˇa\na\na\na\na\na\na\n "}}
{"Key":":"}
{"Key":"2"}
{"Key":","}
{"Key":"5"}
{"Key":"s"}
{"Key":"/"}
{"Key":"^"}
{"Key":"/"}
{"Key":"b"}
{"Key":"enter"}
{"Get":{"state":"a\nba\nba\nba\nˇba\na\na\n ","mode":"Normal"}}
{"Key":"/"}
{"Key":"a"}
{"Key":"enter"}
{"Get":{"state":"a\nba\nba\nba\nbˇa\na\na\n ","mode":"Normal"}}