Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix panic when providing 0 to ilog10 in line number length logic (#26844)

Browse source 
Introduced in #24428

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-03-15 13:10:54 -06:00 • committed by GitHub
parent adbde210fd
commit c220fb387d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/editor/src/element.rs
View file

@ -2151,17 +2151,17 @@ impl EditorElement {
}; };
let editor = self.editor.clone(); let editor = self.editor.clone();
let max_row = self let max_line_number = self
.editor .editor
.read(cx) .read(cx)
.buffer() .buffer()
.read(cx) .read(cx)
.snapshot(cx) .snapshot(cx)
.widest_line_number(); .widest_line_number();
let is_wide = max_row > 999 let is_wide = max_line_number > 999
&& row_info && row_info
.buffer_row .buffer_row
.is_some_and(|row| row.ilog10() == max_row.ilog10()); .is_some_and(|row| (row + 1).ilog10() == max_line_number.ilog10());
let toggle = IconButton::new(("expand", ix), icon_name) let toggle = IconButton::new(("expand", ix), icon_name)
.icon_color(Color::Custom(cx.theme().colors().editor_line_number)) .icon_color(Color::Custom(cx.theme().colors().editor_line_number))