Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Log errors when a prediction fails (#22961)

Browse source 
Release Notes:

- N/A

---------

Co-authored-by: Thorsten <thorsten@zed.dev>
This commit is contained in:
Antonio Scandurra 2025-01-10 15:07:17 +01:00 • committed by GitHub
parent 9e113bccd0
commit c3301077af
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 18 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/zeta/Cargo.toml
View file

@ -39,6 +39,7 @@ telemetry.workspace = true
telemetry_events.workspace = true
theme.workspace = true
ui.workspace = true
util.workspace = true
uuid.workspace = true
workspace.workspace = true

26
crates/zeta/src/zeta.rs
View file

@ -30,6 +30,7 @@ use std::{
time::{Duration, Instant},
};
use telemetry_events::InlineCompletionRating;
use util::ResultExt;
use uuid::Uuid;
const CURSOR_MARKER: &'static str = "<|user_cursor_is_here|>";
@ -975,7 +976,7 @@ impl CurrentInlineCompletion {
struct PendingCompletion {
id: usize,
_task: Task<Result<()>>,
_task: Task<()>,
}
pub struct ZetaInlineCompletionProvider {
@ -1053,13 +1054,16 @@ impl inline_completion::InlineCompletionProvider for ZetaInlineCompletionProvide
})
});
let mut completion = None;
if let Ok(completion_request) = completion_request {
completion = Some(CurrentInlineCompletion {
buffer_id: buffer.entity_id(),
completion: completion_request.await?,
});
}
let completion = match completion_request {
Ok(completion_request) => {
let completion_request = completion_request.await;
completion_request.map(|completion| CurrentInlineCompletion {
buffer_id: buffer.entity_id(),
completion,
})
}
Err(error) => Err(error),
};
this.update(&mut cx, |this, cx| {
if this.pending_completions[0].id == pending_completion_id {
@ -1068,7 +1072,8 @@ impl inline_completion::InlineCompletionProvider for ZetaInlineCompletionProvide
this.pending_completions.clear();
}
if let Some(new_completion) = completion {
if let Some(new_completion) = completion.context("zeta prediction failed").log_err()
{
if let Some(old_completion) = this.current_completion.as_ref() {
let snapshot = buffer.read(cx).snapshot();
if new_completion.should_replace_completion(&old_completion, &snapshot) {
@ -1083,12 +1088,11 @@ impl inline_completion::InlineCompletionProvider for ZetaInlineCompletionProvide
});
this.current_completion = Some(new_completion);
}
} else {
this.current_completion = None;
}
cx.notify();
})
.ok();
});
// We always maintain at most two pending completions. When we already