Hide the implementation of Task (#22009)

The `Option<T>` within `Ready` is confusing and using `None` for it can
cause crashes. There was actually one instance of this!

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2024-12-14 02:52:22 -07:00 committed by GitHub
parent 1ac60289fe
commit c5fe6ef100
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 28 additions and 16 deletions

View file

@ -98,7 +98,7 @@ impl PickerDelegate for KernelPickerDelegate {
if query.is_empty() {
self.filtered_kernels = all_kernels;
return Task::Ready(Some(()));
return Task::ready(());
}
self.filtered_kernels = if query.is_empty() {
@ -110,7 +110,7 @@ impl PickerDelegate for KernelPickerDelegate {
.collect()
};
return Task::Ready(Some(()));
return Task::ready(());
}
fn confirm(&mut self, _secondary: bool, cx: &mut ViewContext<Picker<Self>>) {