Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpui: Include image URI in ImageCacheError::BadStatus (#14910)

Browse source 
This PR updates the `ImageCacheError::BadStatus` variant to include the
URI of the image that failed to load.

This helps contextualize the resulting error logs.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-07-21 10:13:31 -04:00 • committed by GitHub
parent 70f7f2d2da
commit c7331b41e9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/gpui/src/elements/img.rs
View file

@ -375,6 +375,7 @@ impl Asset for Image {
response.body_mut().read_to_end(&mut body).await?; response.body_mut().read_to_end(&mut body).await?;
if !response.status().is_success() { if !response.status().is_success() {
return Err(ImageCacheError::BadStatus { return Err(ImageCacheError::BadStatus {
uri,
status: response.status(), status: response.status(),
body: String::from_utf8_lossy(&body).into_owned(), body: String::from_utf8_lossy(&body).into_owned(),
}); });
@ -417,8 +418,10 @@ pub enum ImageCacheError {
#[error("IO error: {0}")] #[error("IO error: {0}")]
Io(Arc<std::io::Error>), Io(Arc<std::io::Error>),
/// An error that occurred while processing an image. /// An error that occurred while processing an image.
#[error("unexpected http status: {status}, body: {body}")] #[error("unexpected http status for {uri}: {status}, body: {body}")]
BadStatus { BadStatus {
/// The URI of the image.
uri: SharedUri,
/// The HTTP status code. /// The HTTP status code.
status: http::StatusCode, status: http::StatusCode,
/// The HTTP response body. /// The HTTP response body.