From c7963c8a935452a2049a5736bef98cbe807ea541 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Wed, 9 Apr 2025 16:43:38 +0000 Subject: [PATCH] ci: Require workspace_hack for PR merge (#28431) Release Notes: - N/A --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 63749daf63..f312cd7653 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -465,6 +465,7 @@ jobs: - job_spec - style - migration_checks + # run_tests: If adding required tests, add them here and to script below. - workspace_hack - linux_tests - build_remote_server @@ -482,11 +483,14 @@ jobs: # Only check test jobs if they were supposed to run if [[ "${{ needs.job_spec.outputs.run_tests }}" == "true" ]]; then + [[ "${{ needs.workspace_hack.result }}" != 'success' ]] && { RET_CODE=1; echo "Workspace Hack failed"; } [[ "${{ needs.macos_tests.result }}" != 'success' ]] && { RET_CODE=1; echo "macOS tests failed"; } [[ "${{ needs.linux_tests.result }}" != 'success' ]] && { RET_CODE=1; echo "Linux tests failed"; } [[ "${{ needs.windows_tests.result }}" != 'success' ]] && { RET_CODE=1; echo "Windows tests failed"; } [[ "${{ needs.windows_clippy.result }}" != 'success' ]] && { RET_CODE=1; echo "Windows clippy failed"; } [[ "${{ needs.build_remote_server.result }}" != 'success' ]] && { RET_CODE=1; echo "Remote server build failed"; } + # This check is intentionally disabled. See: https://github.com/zed-industries/zed/pull/28431 + # [[ "${{ needs.migration_checks.result }}" != 'success' ]] && { RET_CODE=1; echo "Migration Checks failed"; } fi if [[ "$RET_CODE" -eq 0 ]]; then echo "All tests passed successfully!"