From c84d432b5fcecda1a019eedaface7f28bc21c946 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Tue, 18 Jun 2024 15:50:18 -0400 Subject: [PATCH] Fix modality indicators in user menu (#13228) This PR updates the modality indicators in the user menu after #12940. We use the ellipsis throughout the app to indicate that a menu action will open a modal (e.g., the theme selector), so "Themes" needs the trailing ellipsis. Whereas the "Extensions" entry opens up a new tab, which we don't indicate that same way. Release Notes: - N/A --- crates/collab_ui/src/collab_titlebar_item.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/collab_ui/src/collab_titlebar_item.rs b/crates/collab_ui/src/collab_titlebar_item.rs index a234a2c28d..728552d996 100644 --- a/crates/collab_ui/src/collab_titlebar_item.rs +++ b/crates/collab_ui/src/collab_titlebar_item.rs @@ -911,8 +911,8 @@ impl CollabTitlebarItem { ContextMenu::build(cx, |menu, _| { menu.action("Settings", zed_actions::OpenSettings.boxed_clone()) .action("Key Bindings", Box::new(zed_actions::OpenKeymap)) - .action("Themes", theme_selector::Toggle::default().boxed_clone()) - .action("Extensions...", extensions_ui::Extensions.boxed_clone()) + .action("Themes…", theme_selector::Toggle::default().boxed_clone()) + .action("Extensions", extensions_ui::Extensions.boxed_clone()) .separator() .action("Sign Out", client::SignOut.boxed_clone()) }) @@ -940,8 +940,8 @@ impl CollabTitlebarItem { ContextMenu::build(cx, |menu, _| { menu.action("Settings", zed_actions::OpenSettings.boxed_clone()) .action("Key Bindings", Box::new(zed_actions::OpenKeymap)) - .action("Themes", theme_selector::Toggle::default().boxed_clone()) - .action("Extensions...", extensions_ui::Extensions.boxed_clone()) + .action("Themes…", theme_selector::Toggle::default().boxed_clone()) + .action("Extensions", extensions_ui::Extensions.boxed_clone()) }) .into() })