Improve error handling and resource cleanup in linux/x11/window.rs (#21079)

Browse source

* Fixes registration of event handler for xinput-2 device changes,
revealed by this improvement.

* Pushes `.unwrap()` panic-ing outwards to callers.

* Includes a description of what the X11 call was doing when a failure
was encountered.

* Fixes a variety of places where the X11 reply wasn't being inspected
for failures.

* Destroys windows on failure during setup. New structure makes it
possible for the caller of `open_window` to carry on despite failures,
and so partially initialized window should be removed (though all calls
I looked at also panic currently).

Considered pushing this through `linux/x11/client.rs` too but figured
it'd be nice to minimize merge conflicts with #20853.

Release Notes:

- N/A

...

This commit is contained in:

Michael Sloan 2024-11-22 16:03:46 -07:00 • committed by GitHub

parent 8240a52a39

commit c9f2c2792c

No known key found for this signature in database

GPG key ID: B5690EEEBB952194

3 changed files with 454 additions and 349 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

770

crates/gpui/src/platform/linux/x11/window.rs

View file

File diff suppressed because it is too large Load diff