Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fail faster on serialization failure

Browse source 
Co-Authored-By: Thorsten <thorsten@zed.dev>
This commit is contained in:
Conrad Irwin 2024-01-25 09:59:57 -07:00
parent 7068161bd7
commit ca27ac21c2
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/collab/src/db.rs
View file

@ -303,13 +303,14 @@ impl Database {
} }
} }
async fn retry_on_serialization_error(&self, error: &Error, prev_attempt_count: u32) -> bool { async fn retry_on_serialization_error(&self, error: &Error, prev_attempt_count: usize) -> bool {
// If the error is due to a failure to serialize concurrent transactions, then retry // If the error is due to a failure to serialize concurrent transactions, then retry
// this transaction after a delay. With each subsequent retry, double the delay duration. // this transaction after a delay. With each subsequent retry, double the delay duration.
// Also vary the delay randomly in order to ensure different database connections retry // Also vary the delay randomly in order to ensure different database connections retry
// at different times. // at different times.
if is_serialization_error(error) { const SLEEPS: [f32; 10] = [10., 20., 40., 80., 160., 320., 640., 1280., 2560., 5120.];
let base_delay = 4_u64 << prev_attempt_count.min(16); if is_serialization_error(error) && prev_attempt_count < SLEEPS.len() {
let base_delay = SLEEPS[prev_attempt_count];
let randomized_delay = base_delay as f32 * self.rng.lock().await.gen_range(0.5..=2.0); let randomized_delay = base_delay as f32 * self.rng.lock().await.gen_range(0.5..=2.0);
log::info!( log::info!(
"retrying transaction after serialization error. delay: {} ms.", "retrying transaction after serialization error. delay: {} ms.",