Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use a handler instead of an action for clicks

Browse source 
This prevents dispatching actions on buttons that were not the target of the click.

Co-Authored-By: Marshall <marshall@zed.dev>
This commit is contained in:
Antonio Scandurra 2023-12-06 19:12:01 +01:00
parent e4884f1d76
commit cc9eff89f5
5 changed files with 48 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/assistant2/src/assistant_panel.rs
View file

@ -2574,7 +2574,9 @@ impl Render for InlineAssistant {
.w(measurements.gutter_width)
.child(
IconButton::new("include_conversation", Icon::Ai)
.action(Box::new(ToggleIncludeConversation))
.on_click(cx.listener(|this, _, cx| {
this.toggle_include_conversation(&ToggleIncludeConversation, cx)
}))
.selected(self.include_conversation)
.tooltip(|cx| {
Tooltip::for_action(
@ -2587,7 +2589,9 @@ impl Render for InlineAssistant {
.children(if SemanticIndex::enabled(cx) {
Some(
IconButton::new("retrieve_context", Icon::MagnifyingGlass)
.action(Box::new(ToggleRetrieveContext))
.on_click(cx.listener(|this, _, cx| {
this.toggle_retrieve_context(&ToggleRetrieveContext, cx)
}))
.selected(self.retrieve_context)
.tooltip(|cx| {
Tooltip::for_action(