Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Reject pending tool call confirmations

Browse source
This commit is contained in:
Ben Brandt 2025-07-23 13:21:33 +02:00
parent cea8e61fd9
commit ce5614cc76
No known key found for this signature in database
GPG key ID: D4618C5D3B500571
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/acp_thread/src/acp_thread.rs
View file

@ -1,7 +1,6 @@
mod connection;
pub use connection::*;
pub use acp_old::ToolCallId;
use agent_client_protocol::{self as acp};
use agentic_coding_protocol as acp_old;
use anyhow::{Context as _, Result};
@ -1072,13 +1071,17 @@ impl AcpThread {
mem::replace(&mut call.status, ToolCallStatus::Canceled);
if let ToolCallStatus::WaitingForConfirmation {
respond_tx, ..
respond_tx,
possible_grants,
} = curr_status
{
// todo! do we need a way to cancel rather than reject?
respond_tx
.send(acp_old::ToolCallConfirmationOutcome::Cancel)
.ok();
if let Some(grant_id) = possible_grants
.iter()
.find_map(|g| (!g.is_allowed).then(|| g.id.clone()))
{
// todo! do we need a way to cancel rather than reject?
respond_tx.send(grant_id).ok();
}
}
}
}
@ -1267,7 +1270,7 @@ impl OldAcpClientDelegate {
pub async fn request_existing_tool_call_confirmation(
&self,
tool_call_id: ToolCallId,
tool_call_id: acp_old::ToolCallId,
confirmation: acp_old::ToolCallConfirmation,
) -> Result<acp_old::ToolCallConfirmationOutcome> {
let cx = &mut self.cx.clone();