Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix deafened -> enabled mistranslation

Browse source 
Fix mislocation of caller query in detach_and_log_error
Fix incorrect wording on livekit integration
Add share_mic action for manually enabling the microphone
Make mic sharing wait until the room has been fully established
This commit is contained in:
Mikayla Maki 2023-06-20 15:17:49 -07:00
parent dbd95e35cf
commit cf4251fb55
No known key found for this signature in database
4 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

24
crates/call/src/room.rs
View file

@ -220,15 +220,6 @@ impl Room {
None
};
if option_env!("START_MIC").is_some()
|| &*util::channel::RELEASE_CHANNEL != &ReleaseChannel::Dev
{
let share_mic = room.update(&mut cx, |room, cx| room.share_mic(cx));
cx.update(|cx| {
cx.background().spawn(share_mic).detach_and_log_err(cx);
});
}
match room
.update(&mut cx, |room, cx| {
room.leave_when_empty = true;
@ -236,7 +227,18 @@ impl Room {
})
.await
{
Ok(()) => Ok(room),
Ok(()) => {
if option_env!("START_MIC").is_some()
|| &*util::channel::RELEASE_CHANNEL != &ReleaseChannel::Dev
{
let share_mic = room.update(&mut cx, |room, cx| room.share_mic(cx));
cx.update(|cx| {
cx.background().spawn(share_mic).detach_and_log_err(cx);
});
}
Ok(room)
},
Err(error) => Err(anyhow!("room creation failed: {:?}", error)),
}
})
@ -1201,7 +1203,7 @@ impl Room {
.room
.remote_audio_track_publications(&participant.user.id.to_string())
{
tasks.push(cx.background().spawn(track.set_enabled(live_kit.deafened)));
tasks.push(cx.background().spawn(track.set_enabled(!live_kit.deafened)));
}
}