Added workspace restart command

This commit is contained in:
Mikayla Maki 2023-02-16 10:36:46 -08:00
parent ac882c7db5
commit cf83ecccbb
6 changed files with 58 additions and 10 deletions

1
Cargo.lock generated
View file

@ -1097,6 +1097,7 @@ dependencies = [
"ipc-channel", "ipc-channel",
"plist", "plist",
"serde", "serde",
"sysinfo",
] ]
[[package]] [[package]]

View file

@ -18,6 +18,7 @@ clap = { version = "3.1", features = ["derive"] }
dirs = "3.0" dirs = "3.0"
ipc-channel = "0.16" ipc-channel = "0.16"
serde = { version = "1.0", features = ["derive", "rc"] } serde = { version = "1.0", features = ["derive", "rc"] }
sysinfo = "0.27"
[target.'cfg(target_os = "macos")'.dependencies] [target.'cfg(target_os = "macos")'.dependencies]
core-foundation = "0.9" core-foundation = "0.9"

View file

@ -14,8 +14,10 @@ use std::{
fs::{self, OpenOptions}, fs::{self, OpenOptions},
io, io,
path::{Path, PathBuf}, path::{Path, PathBuf},
ptr, ptr, thread,
time::Duration,
}; };
use sysinfo::{Pid, System, SystemExt};
#[derive(Parser)] #[derive(Parser)]
#[clap(name = "zed", global_setting(clap::AppSettings::NoAutoVersion))] #[clap(name = "zed", global_setting(clap::AppSettings::NoAutoVersion))]
@ -32,6 +34,8 @@ struct Args {
/// Custom Zed.app path /// Custom Zed.app path
#[clap(short, long)] #[clap(short, long)]
bundle_path: Option<PathBuf>, bundle_path: Option<PathBuf>,
#[clap(short, long)]
restart_from: Option<Pid>,
} }
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
@ -60,6 +64,13 @@ fn main() -> Result<()> {
return Ok(()); return Ok(());
} }
if let Some(parent_pid) = args.restart_from {
let mut system = System::new();
while system.refresh_process(parent_pid) {
thread::sleep(Duration::from_millis(100));
}
}
for path in args.paths.iter() { for path in args.paths.iter() {
if !path.exists() { if !path.exists() {
touch(path.as_path())?; touch(path.as_path())?;

View file

@ -101,6 +101,7 @@ actions!(
NewTerminal, NewTerminal,
NewSearch, NewSearch,
Feedback, Feedback,
Restart
] ]
); );

View file

@ -567,6 +567,14 @@ async fn handle_cli_connection(
if let Some(request) = requests.next().await { if let Some(request) = requests.next().await {
match request { match request {
CliRequest::Open { paths, wait } => { CliRequest::Open { paths, wait } => {
let paths = if paths.is_empty() {
workspace::last_opened_workspace_paths()
.await
.map(|location| location.paths().to_vec())
.unwrap_or(paths)
} else {
paths
};
let (workspace, items) = cx let (workspace, items) = cx
.update(|cx| workspace::open_paths(&paths, &app_state, cx)) .update(|cx| workspace::open_paths(&paths, &app_state, cx))
.await; .await;

View file

@ -23,7 +23,8 @@ use gpui::{
}, },
impl_actions, impl_actions,
platform::{WindowBounds, WindowOptions}, platform::{WindowBounds, WindowOptions},
AssetSource, AsyncAppContext, Platform, PromptLevel, TitlebarOptions, ViewContext, WindowKind, AssetSource, AsyncAppContext, Platform, PromptLevel, Task, TitlebarOptions, ViewContext,
WindowKind,
}; };
use language::Rope; use language::Rope;
use lazy_static::lazy_static; use lazy_static::lazy_static;
@ -34,11 +35,11 @@ use search::{BufferSearchBar, ProjectSearchBar};
use serde::Deserialize; use serde::Deserialize;
use serde_json::to_string_pretty; use serde_json::to_string_pretty;
use settings::{keymap_file_json_schema, settings_file_json_schema, Settings}; use settings::{keymap_file_json_schema, settings_file_json_schema, Settings};
use std::{borrow::Cow, env, path::Path, str, sync::Arc}; use std::{borrow::Cow, env, path::Path, process::Command, str, sync::Arc};
use util::{channel::ReleaseChannel, paths, ResultExt, StaffMode}; use util::{channel::ReleaseChannel, paths, ResultExt, StaffMode};
use uuid::Uuid; use uuid::Uuid;
pub use workspace; pub use workspace;
use workspace::{sidebar::SidebarSide, AppState, Workspace}; use workspace::{sidebar::SidebarSide, AppState, Restart, Workspace};
#[derive(Deserialize, Clone, PartialEq)] #[derive(Deserialize, Clone, PartialEq)]
pub struct OpenBrowser { pub struct OpenBrowser {
@ -129,7 +130,10 @@ pub fn init(app_state: &Arc<AppState>, cx: &mut gpui::MutableAppContext) {
} }
}, },
); );
cx.add_global_action(quit); cx.add_global_action(|_: &Quit, cx| {
quit(cx).detach_and_log_err(cx);
});
cx.add_global_action(restart);
cx.add_global_action(move |action: &OpenBrowser, cx| cx.platform().open_url(&action.url)); cx.add_global_action(move |action: &OpenBrowser, cx| cx.platform().open_url(&action.url));
cx.add_global_action(move |_: &IncreaseBufferFontSize, cx| { cx.add_global_action(move |_: &IncreaseBufferFontSize, cx| {
cx.update_global::<Settings, _, _>(|settings, cx| { cx.update_global::<Settings, _, _>(|settings, cx| {
@ -403,7 +407,29 @@ pub fn build_window_options(
} }
} }
fn quit(_: &Quit, cx: &mut gpui::MutableAppContext) { fn restart(_: &Restart, cx: &mut gpui::MutableAppContext) {
let cli_process = dbg!(cx.platform().path_for_auxiliary_executable("cli"))
.log_err()
.and_then(|path| {
Command::new(path)
.args(["--restart-from", &format!("{}", dbg!(std::process::id()))])
.spawn()
.log_err()
});
cx.spawn(|mut cx| async move {
let did_quit = dbg!(cx.update(quit).await?);
if !did_quit {
if let Some(mut cli_process) = cli_process {
cli_process.kill().log_err();
}
}
Ok::<(), anyhow::Error>(())
})
.detach_and_log_err(cx);
}
fn quit(cx: &mut gpui::MutableAppContext) -> Task<Result<bool>> {
let mut workspaces = cx let mut workspaces = cx
.window_ids() .window_ids()
.filter_map(|window_id| cx.root_view::<Workspace>(window_id)) .filter_map(|window_id| cx.root_view::<Workspace>(window_id))
@ -426,7 +452,7 @@ fn quit(_: &Quit, cx: &mut gpui::MutableAppContext) {
.next() .next()
.await; .await;
if answer != Some(0) { if answer != Some(0) {
return Ok(()); return Ok(false);
} }
} }
@ -438,13 +464,13 @@ fn quit(_: &Quit, cx: &mut gpui::MutableAppContext) {
}) })
.await? .await?
{ {
return Ok(()); return Ok(false);
} }
} }
dbg!("about to quit");
cx.platform().quit(); cx.platform().quit();
anyhow::Ok(()) anyhow::Ok(true)
}) })
.detach_and_log_err(cx);
} }
fn about(_: &mut Workspace, _: &About, cx: &mut gpui::ViewContext<Workspace>) { fn about(_: &mut Workspace, _: &About, cx: &mut gpui::ViewContext<Workspace>) {