From d1eb69c6cd9019971e2cffa164c6a44c8b33c7d9 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 26 Jun 2025 10:34:20 -0400 Subject: [PATCH] ci: Improve check_docs skipping (#33455) Follow-up to: https://github.com/zed-industries/zed/pull/33398 Logic there was incomplete. Caused [this failure](https://github.com/zed-industries/zed/actions/runs/15904169712/job/44854558276). Release Notes: - N/A --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 600956c379..3b6e014d25 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -460,8 +460,10 @@ jobs: RET_CODE=0 # Always check style [[ "${{ needs.style.result }}" != 'success' ]] && { RET_CODE=1; echo "style tests failed"; } - [[ "${{ needs.check_docs.result }}" != 'success' ]] && { RET_CODE=1; echo "docs checks failed"; } + if [[ "${{ needs.job_spec.outputs.run_docs }}" == "true" ]]; then + [[ "${{ needs.check_docs.result }}" != 'success' ]] && { RET_CODE=1; echo "docs checks failed"; } + fi # Only check test jobs if they were supposed to run if [[ "${{ needs.job_spec.outputs.run_tests }}" == "true" ]]; then [[ "${{ needs.workspace_hack.result }}" != 'success' ]] && { RET_CODE=1; echo "Workspace Hack failed"; }