Remove edit action markers from edit_prompt.md
(#27785)
https://github.com/zed-industries/zed/pull/27778 removed most occurrences, but there were still some more in `edit_prompt.md` Release Notes: - N/A
This commit is contained in:
parent
edf712d45b
commit
d40b49ceb9
3 changed files with 35 additions and 32 deletions
|
@ -6,7 +6,7 @@ use crate::schema::json_schema_for;
|
||||||
use anyhow::{anyhow, Context, Result};
|
use anyhow::{anyhow, Context, Result};
|
||||||
use assistant_tool::{ActionLog, Tool};
|
use assistant_tool::{ActionLog, Tool};
|
||||||
use collections::HashSet;
|
use collections::HashSet;
|
||||||
use edit_action::{EditAction, EditActionParser};
|
use edit_action::{edit_model_prompt, EditAction, EditActionParser};
|
||||||
use futures::{channel::mpsc, SinkExt, StreamExt};
|
use futures::{channel::mpsc, SinkExt, StreamExt};
|
||||||
use gpui::{App, AppContext, AsyncApp, Entity, Task};
|
use gpui::{App, AppContext, AsyncApp, Entity, Task};
|
||||||
use language_model::LanguageModelToolSchemaFormat;
|
use language_model::LanguageModelToolSchemaFormat;
|
||||||
|
@ -230,10 +230,7 @@ impl EditToolRequest {
|
||||||
|
|
||||||
messages.push(LanguageModelRequestMessage {
|
messages.push(LanguageModelRequestMessage {
|
||||||
role: Role::User,
|
role: Role::User,
|
||||||
content: vec![
|
content: vec![edit_model_prompt().into(), input.edit_instructions.into()],
|
||||||
include_str!("./edit_files_tool/edit_prompt.md").into(),
|
|
||||||
input.edit_instructions.into(),
|
|
||||||
],
|
|
||||||
cache: false,
|
cache: false,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
@ -342,6 +342,14 @@ impl std::fmt::Display for ParseError {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn edit_model_prompt() -> String {
|
||||||
|
include_str!("edit_prompt.md")
|
||||||
|
.to_string()
|
||||||
|
.replace("{{SEARCH_MARKER}}", SEARCH_MARKER)
|
||||||
|
.replace("{{DIVIDER}}", DIVIDER)
|
||||||
|
.replace("{{REPLACE_MARKER}}", REPLACE_MARKER)
|
||||||
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
|
@ -808,19 +816,17 @@ fn new_utils_func() {{}}
|
||||||
assert_eq!(parser.state, State::Default);
|
assert_eq!(parser.state, State::Default);
|
||||||
}
|
}
|
||||||
|
|
||||||
const SYSTEM_PROMPT: &str = include_str!("./edit_prompt.md");
|
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_parse_examples_in_system_prompt() {
|
fn test_parse_examples_in_edit_prompt() {
|
||||||
let mut parser = EditActionParser::new();
|
let mut parser = EditActionParser::new();
|
||||||
let actions = parser.parse_chunk(SYSTEM_PROMPT);
|
let actions = parser.parse_chunk(&edit_model_prompt());
|
||||||
assert_examples_in_system_prompt(&actions, parser.errors());
|
assert_examples_in_edit_prompt(&actions, parser.errors());
|
||||||
}
|
}
|
||||||
|
|
||||||
#[gpui::test(iterations = 10)]
|
#[gpui::test(iterations = 10)]
|
||||||
fn test_random_chunking_of_system_prompt(mut rng: StdRng) {
|
fn test_random_chunking_of_edit_prompt(mut rng: StdRng) {
|
||||||
let mut parser = EditActionParser::new();
|
let mut parser = EditActionParser::new();
|
||||||
let mut remaining = SYSTEM_PROMPT;
|
let mut remaining: &str = &edit_model_prompt();
|
||||||
let mut actions = Vec::with_capacity(5);
|
let mut actions = Vec::with_capacity(5);
|
||||||
|
|
||||||
while !remaining.is_empty() {
|
while !remaining.is_empty() {
|
||||||
|
@ -833,10 +839,10 @@ fn new_utils_func() {{}}
|
||||||
remaining = rest;
|
remaining = rest;
|
||||||
}
|
}
|
||||||
|
|
||||||
assert_examples_in_system_prompt(&actions, parser.errors());
|
assert_examples_in_edit_prompt(&actions, parser.errors());
|
||||||
}
|
}
|
||||||
|
|
||||||
fn assert_examples_in_system_prompt(actions: &[(EditAction, String)], errors: &[ParseError]) {
|
fn assert_examples_in_edit_prompt(actions: &[(EditAction, String)], errors: &[ParseError]) {
|
||||||
assert_eq!(actions.len(), 5);
|
assert_eq!(actions.len(), 5);
|
||||||
|
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
|
|
|
@ -30,17 +30,17 @@ Here are the *SEARCH/REPLACE* blocks:
|
||||||
|
|
||||||
mathweb/flask/app.py
|
mathweb/flask/app.py
|
||||||
```python
|
```python
|
||||||
<<<<<<< SEARCH
|
{{SEARCH_MARKER}}
|
||||||
from flask import Flask
|
from flask import Flask
|
||||||
=======
|
{{DIVIDER}}
|
||||||
import math
|
import math
|
||||||
from flask import Flask
|
from flask import Flask
|
||||||
>>>>>>> REPLACE
|
{{REPLACE_MARKER}}
|
||||||
```
|
```
|
||||||
|
|
||||||
mathweb/flask/app.py
|
mathweb/flask/app.py
|
||||||
```python
|
```python
|
||||||
<<<<<<< SEARCH
|
{{SEARCH_MARKER}}
|
||||||
def factorial(n):
|
def factorial(n):
|
||||||
"compute factorial"
|
"compute factorial"
|
||||||
|
|
||||||
|
@ -49,17 +49,17 @@ def factorial(n):
|
||||||
else:
|
else:
|
||||||
return n * factorial(n-1)
|
return n * factorial(n-1)
|
||||||
|
|
||||||
=======
|
{{DIVIDER}}
|
||||||
>>>>>>> REPLACE
|
{{REPLACE_MARKER}}
|
||||||
```
|
```
|
||||||
|
|
||||||
mathweb/flask/app.py
|
mathweb/flask/app.py
|
||||||
```python
|
```python
|
||||||
<<<<<<< SEARCH
|
{{SEARCH_MARKER}}
|
||||||
return str(factorial(n))
|
return str(factorial(n))
|
||||||
=======
|
{{DIVIDER}}
|
||||||
return str(math.factorial(n))
|
return str(math.factorial(n))
|
||||||
>>>>>>> REPLACE
|
{{REPLACE_MARKER}}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|
||||||
|
@ -74,36 +74,36 @@ Here are the *SEARCH/REPLACE* blocks:
|
||||||
|
|
||||||
hello.py
|
hello.py
|
||||||
```python
|
```python
|
||||||
<<<<<<< SEARCH
|
{{SEARCH_MARKER}}
|
||||||
=======
|
{{DIVIDER}}
|
||||||
def hello():
|
def hello():
|
||||||
"print a greeting"
|
"print a greeting"
|
||||||
|
|
||||||
print("hello")
|
print("hello")
|
||||||
>>>>>>> REPLACE
|
{{REPLACE_MARKER}}
|
||||||
```
|
```
|
||||||
|
|
||||||
main.py
|
main.py
|
||||||
```python
|
```python
|
||||||
<<<<<<< SEARCH
|
{{SEARCH_MARKER}}
|
||||||
def hello():
|
def hello():
|
||||||
"print a greeting"
|
"print a greeting"
|
||||||
|
|
||||||
print("hello")
|
print("hello")
|
||||||
=======
|
{{DIVIDER}}
|
||||||
from hello import hello
|
from hello import hello
|
||||||
>>>>>>> REPLACE
|
{{REPLACE_MARKER}}
|
||||||
```
|
```
|
||||||
# *SEARCH/REPLACE block* Rules:
|
# *SEARCH/REPLACE block* Rules:
|
||||||
|
|
||||||
Every *SEARCH/REPLACE block* must use this format:
|
Every *SEARCH/REPLACE block* must use this format:
|
||||||
1. The *FULL* file path alone on a line, verbatim. No bold asterisks, no quotes around it, no escaping of characters, etc.
|
1. The *FULL* file path alone on a line, verbatim. No bold asterisks, no quotes around it, no escaping of characters, etc.
|
||||||
2. The opening fence and code language, eg: ```python
|
2. The opening fence and code language, eg: ```python
|
||||||
3. The start of search block: <<<<<<< SEARCH
|
3. The start of search block: {{SEARCH_MARKER}}
|
||||||
4. A contiguous chunk of lines to search for in the existing source code
|
4. A contiguous chunk of lines to search for in the existing source code
|
||||||
5. The dividing line: =======
|
5. The dividing line: {{DIVIDER}}
|
||||||
6. The lines to replace into the source code
|
6. The lines to replace into the source code
|
||||||
7. The end of the replace block: >>>>>>> REPLACE
|
7. The end of the replace block: {{REPLACE_MARKER}}
|
||||||
8. The closing fence: ```
|
8. The closing fence: ```
|
||||||
|
|
||||||
Use the *FULL* file path, as shown to you by the user. Make sure to include the project's root directory name at the start of the path. *NEVER* specify the absolute path of the file!
|
Use the *FULL* file path, as shown to you by the user. Make sure to include the project's root directory name at the start of the path. *NEVER* specify the absolute path of the file!
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue