Don't send dummy user text with tool results (#29099)
Previously, we were including the dummy text "Here are the tool results." whenever reporting tool call results. I'm worried this is adding noise and confusing the model, because the user didn't actually say anything. This inserts an empty message to be populated later. My preference would be something less stateful, where tool results (or batches of them requested simultaneously) would be sent to the model as soon as they were ready, without bothering to do this message association dance. But for now, this seems to work. Release Notes: - N/A
This commit is contained in:
parent
bafc086d27
commit
d48152d958
1 changed files with 4 additions and 3 deletions
|
@ -1663,9 +1663,10 @@ impl Thread {
|
||||||
|
|
||||||
/// Insert an empty message to be populated with tool results upon send.
|
/// Insert an empty message to be populated with tool results upon send.
|
||||||
pub fn attach_tool_results(&mut self, cx: &mut Context<Self>) {
|
pub fn attach_tool_results(&mut self, cx: &mut Context<Self>) {
|
||||||
// TODO: Don't insert a dummy user message here. Ensure this works with the thinking model.
|
// Tool results are assumed to be waiting on the next message id, so they will populate
|
||||||
// Insert a user message to contain the tool results.
|
// this empty message before sending to model. Would prefer this to be more straightforward.
|
||||||
self.insert_user_message("Here are the tool results.", Vec::new(), None, cx);
|
self.insert_message(Role::User, vec![], cx);
|
||||||
|
self.auto_capture_telemetry(cx);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Cancels the last pending completion, if there are any pending.
|
/// Cancels the last pending completion, if there are any pending.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue