Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debugger: Do not query threads when session is still building (#32852)

Browse source 
This should silence a noisy log we see whenever a debug session is
started:
`2025-06-17T12:06:12+02:00 ERROR [project] no adapter running to send
request: ThreadsCommand`

Closes #ISSUE

Release Notes:

- Fixed debugger logs getting clobbered with internal logs about Threads
Command whenever a new debug session is created.
This commit is contained in:
Piotr Osiewicz 2025-06-17 12:36:46 +02:00 • committed by GitHub
parent 4b88090cca
commit d4c9522da7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

21
crates/debugger_ui/src/debugger_panel.rs
View file

@ -858,16 +858,21 @@ impl DebugPanel {
let threads =
running_state.update(cx, |running_state, cx| {
let session = running_state.session();
session
.update(cx, |session, cx| session.threads(cx))
session.read(cx).is_running().then(|| {
session.update(cx, |session, cx| {
session.threads(cx)
})
})
});
self.render_thread_dropdown(
&running_state,
threads,
window,
cx,
)
threads.and_then(|threads| {
self.render_thread_dropdown(
&running_state,
threads,
window,
cx,
)
})
})
.when(!is_side, |this| this.gap_2().child(Divider::vertical()))
},