Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make code block eval resilient to indentation (#29633)

Browse source 
This reduces spurious failures in the eval.

Release Notes:

- N/A
This commit is contained in:
Richard Feldman 2025-04-29 22:13:13 -04:00 • committed by GitHub
parent 75a9ed164b
commit d566864891
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 34 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

28
crates/eval/src/examples/code_block_citations.rs
View file

@ -101,8 +101,13 @@ impl Example for CodeBlockCitations {
let content =
&text[(citation.len() + 1)..content_len - (citation.len() + 1)];
// deindent (trim the start of each line) because sometimes the model
// chooses to deindent its code snippets for the sake of readability,
// which in markdown is not only reasonable but usually desirable.
cx.assert(
buffer_text.contains(&content),
deindent(&buffer_text)
.trim()
.contains(deindent(&content).trim()),
"Code block content was found in file",
)
.ok();
@ -129,10 +134,16 @@ impl Example for CodeBlockCitations {
.to_string();
}
// deindent (trim the start of each line) because sometimes the model
// chooses to deindent its code snippets for the sake of readability,
// which in markdown is not only reasonable but usually desirable.
cx.assert_eq(
snippet.as_str(),
content,
"Code block snippet was at specified line/col",
deindent(snippet.as_str()).trim(),
deindent(content).trim(),
format!(
"Code block was at {:?}-{:?}",
range.start, range.end
),
)
.ok();
}
@ -189,3 +200,12 @@ impl Example for CodeBlockCitations {
]
}
}
fn deindent(as_str: impl AsRef<str>) -> String {
as_str
.as_ref()
.lines()
.map(|line| line.trim_start())
.collect::<Vec<&str>>()
.join("\n")
}