Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

edit predictions: Rename edit prediction modes (#25657)

Browse source 
`auto` -> `stealth`
`eager_preview` -> `eager`

Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
This commit is contained in:
Agus Zubiaga 2025-02-26 17:23:39 -03:00 • committed by GitHub
parent 7a34dd9888
commit d694458659
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
assets/settings/default.json
View file

@ -840,11 +840,11 @@
], ],
// When to show edit predictions previews in buffer. // When to show edit predictions previews in buffer.
// This setting takes two possible values: // This setting takes two possible values:
// 1. Display inline when there are no language server completions available. // 1. Display predictions inline when there are no language server completions available.
// "mode": "eager_preview" // "mode": "eager"
// 2. Display inline when holding modifier key (alt by default). // 2. Display predictions inline only when holding a modifier key (alt by default).
// "mode": "auto" // "mode": "subtle"
"mode": "eager_preview" "mode": "eager"
}, },
// Settings specific to journaling // Settings specific to journaling
"journal": { "journal": {

2
crates/editor/src/editor.rs
View file

@ -4959,7 +4959,7 @@ impl Editor {
}); });
let preview_requires_modifier = let preview_requires_modifier =
all_language_settings(file, cx).edit_predictions_mode() == EditPredictionsMode::Auto; all_language_settings(file, cx).edit_predictions_mode() == EditPredictionsMode::Subtle;
EditPredictionSettings::Enabled { EditPredictionSettings::Enabled {
show_in_menu, show_in_menu,

8
crates/inline_completion_button/src/inline_completion_button.rs
View file

@ -592,8 +592,8 @@ impl InlineCompletionButton {
if cx.has_flag::<feature_flags::PredictEditsNonEagerModeFeatureFlag>() { if cx.has_flag::<feature_flags::PredictEditsNonEagerModeFeatureFlag>() {
let is_eager_preview_enabled = match settings.edit_predictions_mode() { let is_eager_preview_enabled = match settings.edit_predictions_mode() {
language::EditPredictionsMode::Auto => false, language::EditPredictionsMode::Subtle => false,
language::EditPredictionsMode::EagerPreview => true, language::EditPredictionsMode::Eager => true,
}; };
menu = menu.separator().toggleable_entry( menu = menu.separator().toggleable_entry(
"Eager Preview Mode", "Eager Preview Mode",
@ -608,8 +608,8 @@ impl InlineCompletionButton {
cx, cx,
move |settings, _cx| { move |settings, _cx| {
let new_mode = match is_eager_preview_enabled { let new_mode = match is_eager_preview_enabled {
true => language::EditPredictionsMode::Auto, true => language::EditPredictionsMode::Subtle,
false => language::EditPredictionsMode::EagerPreview, false => language::EditPredictionsMode::Eager,
}; };
if let Some(edit_predictions) = settings.edit_predictions.as_mut() { if let Some(edit_predictions) = settings.edit_predictions.as_mut() {

5
crates/language/src/language_settings.rs
View file

@ -244,10 +244,11 @@ pub struct EditPredictionSettings {
pub enum EditPredictionsMode { pub enum EditPredictionsMode {
/// If provider supports it, display inline when holding modifier key (e.g., alt). /// If provider supports it, display inline when holding modifier key (e.g., alt).
/// Otherwise, eager preview is used. /// Otherwise, eager preview is used.
Auto, Subtle,
/// Display inline when there are no language server completions available. /// Display inline when there are no language server completions available.
#[default] #[default]
EagerPreview, #[serde(alias = "eager_preview")]
Eager,
} }
#[derive(Clone, Debug, Default)] #[derive(Clone, Debug, Default)]