Allow enabling/disabling breakpoints (#27280)
This PR adds the ability to enable/disable breakpoints. It also fixes a bug where toggling a log breakpoint from the breakpoint context menu would add a standard breakpoint on top of the log breakpoint instead of deleting it. todo: - [x] Add `BreakpointState` field Breakpoint that manages if a breakpoint is active or not - [x] Don't send disabled breakpoints to DAP servers - in progress - [x] Half the opacity of disabled breakpoints - in progress - [x] Add `BreakpointState` to database - [x] Editor test for enabling/disabling breakpoints - [ ] Integration Test to make sure we don't send disabled breakpoints to DAP servers - [x] Database test to make sure we properly serialize/deserialize BreakpointState Release Notes: - N/A --------- Co-authored-by: Piotr <piotr@zed.dev> Co-authored-by: Conrad <conrad@zed.dev> Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
This commit is contained in:
parent
df583d73b9
commit
d70ac64fe4
9 changed files with 583 additions and 172 deletions
|
@ -358,6 +358,7 @@ impl LocalMode {
|
|||
.breakpoint_store
|
||||
.read_with(cx, |store, cx| store.breakpoints_from_path(&abs_path, cx))
|
||||
.into_iter()
|
||||
.filter(|bp| bp.state.is_enabled())
|
||||
.map(Into::into)
|
||||
.collect();
|
||||
|
||||
|
@ -388,7 +389,11 @@ impl LocalMode {
|
|||
let breakpoints = if ignore_breakpoints {
|
||||
vec![]
|
||||
} else {
|
||||
breakpoints.into_iter().map(Into::into).collect()
|
||||
breakpoints
|
||||
.into_iter()
|
||||
.filter(|bp| bp.state.is_enabled())
|
||||
.map(Into::into)
|
||||
.collect()
|
||||
};
|
||||
|
||||
breakpoint_tasks.push(self.request(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue