From d97a58b20eb9e64c61b9644526872fa4994a2467 Mon Sep 17 00:00:00 2001 From: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Date: Fri, 20 Jun 2025 03:53:32 -0400 Subject: [PATCH] debugger: Refresh variable list on set variable value response (#33078) Variable list wasn't notified when a set variable value request was successfully. This caused the variable list and inline values to show stale data in some cases, which this PR fixes. Release Notes: - debugger: Fix bug where setting a variable's value wouldn't update the variable list or inline values --- crates/project/src/debugger/session.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/project/src/debugger/session.rs b/crates/project/src/debugger/session.rs index 116c07d625..8047e028af 100644 --- a/crates/project/src/debugger/session.rs +++ b/crates/project/src/debugger/session.rs @@ -1323,7 +1323,6 @@ impl Session { if event.all_threads_stopped.unwrap_or_default() || event.thread_id.is_none() { self.thread_states.stop_all_threads(); - self.invalidate_command_type::(); } @@ -2207,7 +2206,7 @@ impl Session { move |this, response, cx| { let response = response.log_err()?; this.invalidate_command_type::(); - cx.notify(); + cx.emit(SessionEvent::Variables); Some(response) }, cx, @@ -2275,7 +2274,6 @@ impl Session { this.push_output(event, cx); } }; - this.invalidate_command_type::(); cx.notify(); }) .ok();