Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant2: Inline read calls (#22982)

Browse source 
This PR inlines the `read` calls on models in a few spots.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2025-01-10 16:54:50 -05:00 • committed by GitHub
parent 0f1c2a8d01
commit dad1a3bd31
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/assistant2/src/context_store.rs
View file

@ -260,10 +260,9 @@ impl ContextStore {
pub fn insert_thread(&mut self, thread: Model<Thread>, cx: &AppContext) { pub fn insert_thread(&mut self, thread: Model<Thread>, cx: &AppContext) {
let id = self.next_context_id.post_inc(); let id = self.next_context_id.post_inc();
let thread_ref = thread.read(cx); let text = thread.read(cx).text().into();
let text = thread_ref.text().into();
self.threads.insert(thread_ref.id().clone(), id); self.threads.insert(thread.read(cx).id().clone(), id);
self.context self.context
.push(Context::Thread(ThreadContext { id, thread, text })); .push(Context::Thread(ThreadContext { id, thread, text }));
} }
@ -499,8 +498,7 @@ pub fn refresh_context_store_text(
cx: &AppContext, cx: &AppContext,
) -> impl Future<Output = ()> { ) -> impl Future<Output = ()> {
let mut tasks = Vec::new(); let mut tasks = Vec::new();
let context_store_ref = context_store.read(cx); for context in &context_store.read(cx).context {
for context in &context_store_ref.context {
match context { match context {
Context::File(file_context) => { Context::File(file_context) => {
let context_store = context_store.clone(); let context_store = context_store.clone();