Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add stray UI polish to the SSH flow (#17798)

Browse source 
Some super subtle refinement opportunities I spotted while playing
around with this flow. There are mostly copywriting tweaks and some UI
tweaks here and there (including editing the modal horizontal padding).

--- 

Release Notes:

- N/A
This commit is contained in:
Danilo Leal 2024-09-13 16:05:34 -04:00 • committed by GitHub
parent c71f052276
commit e145c13f73
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 20 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/ui/src/components/modal.rs
View file

@ -1,6 +1,6 @@
use crate::{
h_flex, rems_from_px, v_flex, Clickable, Color, Headline, HeadlineSize, IconButton,
IconButtonShape, IconName, Label, LabelCommon, LabelSize, Spacing,
h_flex, v_flex, Clickable, Color, Headline, HeadlineSize, IconButton, IconButtonShape,
IconName, Label, LabelCommon, LabelSize, Spacing,
};
use gpui::{prelude::FluentBuilder, *};
use smallvec::SmallVec;
@ -210,7 +210,7 @@ impl ParentElement for ModalRow {
impl RenderOnce for ModalRow {
fn render(self, _cx: &mut WindowContext) -> impl IntoElement {
h_flex().w_full().px_2().py_1().children(self.children)
h_flex().w_full().py_1().children(self.children)
}
}
@ -326,7 +326,6 @@ impl RenderOnce for Section {
.border_color(cx.theme().colors().border)
.bg(section_bg)
.py(Spacing::Medium.rems(cx))
.px(Spacing::Large.rems(cx) - rems_from_px(1.0))
.gap_y(Spacing::Small.rems(cx))
.child(div().flex().flex_1().size_full().children(self.children)),
)
@ -334,7 +333,7 @@ impl RenderOnce for Section {
v_flex()
.w_full()
.gap_y(Spacing::Small.rems(cx))
.px(Spacing::Large.rems(cx) + Spacing::Large.rems(cx))
.px(Spacing::Medium.rems(cx) + Spacing::Medium.rems(cx))
.children(self.children)
};