Fix tasks not being stopped on reruns (#29786)
Follow-up of https://github.com/zed-industries/zed/pull/28993
* Tone down tasks' cancellation logging
* Fix task terminals' leak, disallowing to fully cancel the task by
dropping the terminal off the pane:
f619d5f02a/crates/terminal_view/src/terminal_panel.rs (L1464-L1471)
Release Notes:
- Fixed tasks not being stopped on reruns
This commit is contained in:
parent
460ac96df4
commit
e14d078f8a
6 changed files with 69 additions and 41 deletions
|
@ -6,7 +6,7 @@ use crate::{
|
|||
persistence,
|
||||
};
|
||||
use crate::{new_session_modal::NewSessionModal, session::DebugSession};
|
||||
use anyhow::{Result, anyhow};
|
||||
use anyhow::{Context as _, Result, anyhow};
|
||||
use collections::{HashMap, HashSet};
|
||||
use command_palette_hooks::CommandPaletteFilter;
|
||||
use dap::DebugRequest;
|
||||
|
@ -500,7 +500,7 @@ impl DebugPanel {
|
|||
workspace.spawn_in_terminal(task.resolved.clone(), window, cx)
|
||||
})?;
|
||||
|
||||
let exit_status = run_build.await?;
|
||||
let exit_status = run_build.await.transpose()?.context("task cancelled")?;
|
||||
if !exit_status.success() {
|
||||
anyhow::bail!("Build failed");
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue