Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix panic in update_ime_position (#21510)

Browse source 
This can call back into the app, so must be done when the platform lock
is not
held.

Release Notes:

- Fixes a (rare) panic when changing tab
This commit is contained in:
Conrad Irwin 2024-12-03 22:20:25 -08:00 • committed by GitHub
parent 8f08787cf0
commit e231321655
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/gpui/src/platform/mac/window.rs
View file

@ -1111,10 +1111,16 @@ impl PlatformWindow for MacWindow {
} }
fn update_ime_position(&self, _bounds: Bounds<ScaledPixels>) { fn update_ime_position(&self, _bounds: Bounds<ScaledPixels>) {
unsafe { let executor = self.0.lock().executor.clone();
let input_context: id = msg_send![class!(NSTextInputContext), currentInputContext]; executor
let _: () = msg_send![input_context, invalidateCharacterCoordinates]; .spawn(async move {
} unsafe {
let input_context: id =
msg_send![class!(NSTextInputContext), currentInputContext];
let _: () = msg_send![input_context, invalidateCharacterCoordinates];
}
})
.detach()
} }
} }