Add active pane magnification setting which grows the active pane making it easier to see it's contents
This commit is contained in:
parent
076d353e84
commit
e2ba8d6df7
4 changed files with 273 additions and 230 deletions
|
@ -5,6 +5,9 @@
|
||||||
"buffer_font_family": "Zed Mono",
|
"buffer_font_family": "Zed Mono",
|
||||||
// The default font size for text in the editor
|
// The default font size for text in the editor
|
||||||
"buffer_font_size": 15,
|
"buffer_font_size": 15,
|
||||||
|
// The factor to grow the active pane by. Defaults to 1.0
|
||||||
|
// which gives the same size as all other panes.
|
||||||
|
"active_pane_magnification": 1.0,
|
||||||
// Whether to enable vim modes and key bindings
|
// Whether to enable vim modes and key bindings
|
||||||
"vim_mode": false,
|
"vim_mode": false,
|
||||||
// Whether to show the informational hover box when moving the mouse
|
// Whether to show the informational hover box when moving the mouse
|
||||||
|
|
|
@ -28,6 +28,7 @@ pub struct Settings {
|
||||||
pub buffer_font_family: FamilyId,
|
pub buffer_font_family: FamilyId,
|
||||||
pub default_buffer_font_size: f32,
|
pub default_buffer_font_size: f32,
|
||||||
pub buffer_font_size: f32,
|
pub buffer_font_size: f32,
|
||||||
|
pub active_pane_magnification: f32,
|
||||||
pub cursor_blink: bool,
|
pub cursor_blink: bool,
|
||||||
pub hover_popover_enabled: bool,
|
pub hover_popover_enabled: bool,
|
||||||
pub show_completions_on_input: bool,
|
pub show_completions_on_input: bool,
|
||||||
|
@ -235,6 +236,8 @@ pub struct SettingsFileContent {
|
||||||
#[serde(default)]
|
#[serde(default)]
|
||||||
pub buffer_font_size: Option<f32>,
|
pub buffer_font_size: Option<f32>,
|
||||||
#[serde(default)]
|
#[serde(default)]
|
||||||
|
pub active_pane_magnification: Option<f32>,
|
||||||
|
#[serde(default)]
|
||||||
pub cursor_blink: Option<bool>,
|
pub cursor_blink: Option<bool>,
|
||||||
#[serde(default)]
|
#[serde(default)]
|
||||||
pub hover_popover_enabled: Option<bool>,
|
pub hover_popover_enabled: Option<bool>,
|
||||||
|
@ -294,6 +297,7 @@ impl Settings {
|
||||||
.load_family(&[defaults.buffer_font_family.as_ref().unwrap()])
|
.load_family(&[defaults.buffer_font_family.as_ref().unwrap()])
|
||||||
.unwrap(),
|
.unwrap(),
|
||||||
buffer_font_size: defaults.buffer_font_size.unwrap(),
|
buffer_font_size: defaults.buffer_font_size.unwrap(),
|
||||||
|
active_pane_magnification: defaults.active_pane_magnification.unwrap(),
|
||||||
default_buffer_font_size: defaults.buffer_font_size.unwrap(),
|
default_buffer_font_size: defaults.buffer_font_size.unwrap(),
|
||||||
cursor_blink: defaults.cursor_blink.unwrap(),
|
cursor_blink: defaults.cursor_blink.unwrap(),
|
||||||
hover_popover_enabled: defaults.hover_popover_enabled.unwrap(),
|
hover_popover_enabled: defaults.hover_popover_enabled.unwrap(),
|
||||||
|
@ -349,6 +353,10 @@ impl Settings {
|
||||||
data.projects_online_by_default,
|
data.projects_online_by_default,
|
||||||
);
|
);
|
||||||
merge(&mut self.buffer_font_size, data.buffer_font_size);
|
merge(&mut self.buffer_font_size, data.buffer_font_size);
|
||||||
|
merge(
|
||||||
|
&mut self.active_pane_magnification,
|
||||||
|
data.active_pane_magnification,
|
||||||
|
);
|
||||||
merge(&mut self.default_buffer_font_size, data.buffer_font_size);
|
merge(&mut self.default_buffer_font_size, data.buffer_font_size);
|
||||||
merge(&mut self.cursor_blink, data.cursor_blink);
|
merge(&mut self.cursor_blink, data.cursor_blink);
|
||||||
merge(&mut self.hover_popover_enabled, data.hover_popover_enabled);
|
merge(&mut self.hover_popover_enabled, data.hover_popover_enabled);
|
||||||
|
@ -440,6 +448,7 @@ impl Settings {
|
||||||
experiments: FeatureFlags::default(),
|
experiments: FeatureFlags::default(),
|
||||||
buffer_font_family: cx.font_cache().load_family(&["Monaco"]).unwrap(),
|
buffer_font_family: cx.font_cache().load_family(&["Monaco"]).unwrap(),
|
||||||
buffer_font_size: 14.,
|
buffer_font_size: 14.,
|
||||||
|
active_pane_magnification: 1.,
|
||||||
default_buffer_font_size: 14.,
|
default_buffer_font_size: 14.,
|
||||||
cursor_blink: true,
|
cursor_blink: true,
|
||||||
hover_popover_enabled: true,
|
hover_popover_enabled: true,
|
||||||
|
|
|
@ -6,6 +6,7 @@ use gpui::{
|
||||||
};
|
};
|
||||||
use project::Project;
|
use project::Project;
|
||||||
use serde::Deserialize;
|
use serde::Deserialize;
|
||||||
|
use settings::Settings;
|
||||||
use theme::Theme;
|
use theme::Theme;
|
||||||
|
|
||||||
#[derive(Clone, Debug, Eq, PartialEq)]
|
#[derive(Clone, Debug, Eq, PartialEq)]
|
||||||
|
@ -61,10 +62,17 @@ impl PaneGroup {
|
||||||
theme: &Theme,
|
theme: &Theme,
|
||||||
follower_states: &FollowerStatesByLeader,
|
follower_states: &FollowerStatesByLeader,
|
||||||
active_call: Option<&ModelHandle<ActiveCall>>,
|
active_call: Option<&ModelHandle<ActiveCall>>,
|
||||||
|
active_pane: &ViewHandle<Pane>,
|
||||||
cx: &mut RenderContext<Workspace>,
|
cx: &mut RenderContext<Workspace>,
|
||||||
) -> ElementBox {
|
) -> ElementBox {
|
||||||
self.root
|
self.root.render(
|
||||||
.render(project, theme, follower_states, active_call, cx)
|
project,
|
||||||
|
theme,
|
||||||
|
follower_states,
|
||||||
|
active_call,
|
||||||
|
active_pane,
|
||||||
|
cx,
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub(crate) fn panes(&self) -> Vec<&ViewHandle<Pane>> {
|
pub(crate) fn panes(&self) -> Vec<&ViewHandle<Pane>> {
|
||||||
|
@ -102,12 +110,20 @@ impl Member {
|
||||||
Member::Axis(PaneAxis { axis, members })
|
Member::Axis(PaneAxis { axis, members })
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn contains(&self, needle: &ViewHandle<Pane>) -> bool {
|
||||||
|
match self {
|
||||||
|
Member::Axis(axis) => axis.members.iter().any(|member| member.contains(needle)),
|
||||||
|
Member::Pane(pane) => pane == needle,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
pub fn render(
|
pub fn render(
|
||||||
&self,
|
&self,
|
||||||
project: &ModelHandle<Project>,
|
project: &ModelHandle<Project>,
|
||||||
theme: &Theme,
|
theme: &Theme,
|
||||||
follower_states: &FollowerStatesByLeader,
|
follower_states: &FollowerStatesByLeader,
|
||||||
active_call: Option<&ModelHandle<ActiveCall>>,
|
active_call: Option<&ModelHandle<ActiveCall>>,
|
||||||
|
active_pane: &ViewHandle<Pane>,
|
||||||
cx: &mut RenderContext<Workspace>,
|
cx: &mut RenderContext<Workspace>,
|
||||||
) -> ElementBox {
|
) -> ElementBox {
|
||||||
enum FollowIntoExternalProject {}
|
enum FollowIntoExternalProject {}
|
||||||
|
@ -234,7 +250,14 @@ impl Member {
|
||||||
.with_children(prompt)
|
.with_children(prompt)
|
||||||
.boxed()
|
.boxed()
|
||||||
}
|
}
|
||||||
Member::Axis(axis) => axis.render(project, theme, follower_states, active_call, cx),
|
Member::Axis(axis) => axis.render(
|
||||||
|
project,
|
||||||
|
theme,
|
||||||
|
follower_states,
|
||||||
|
active_call,
|
||||||
|
active_pane,
|
||||||
|
cx,
|
||||||
|
),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -340,12 +363,19 @@ impl PaneAxis {
|
||||||
theme: &Theme,
|
theme: &Theme,
|
||||||
follower_state: &FollowerStatesByLeader,
|
follower_state: &FollowerStatesByLeader,
|
||||||
active_call: Option<&ModelHandle<ActiveCall>>,
|
active_call: Option<&ModelHandle<ActiveCall>>,
|
||||||
|
active_pane: &ViewHandle<Pane>,
|
||||||
cx: &mut RenderContext<Workspace>,
|
cx: &mut RenderContext<Workspace>,
|
||||||
) -> ElementBox {
|
) -> ElementBox {
|
||||||
let last_member_ix = self.members.len() - 1;
|
let last_member_ix = self.members.len() - 1;
|
||||||
Flex::new(self.axis)
|
Flex::new(self.axis)
|
||||||
.with_children(self.members.iter().enumerate().map(|(ix, member)| {
|
.with_children(self.members.iter().enumerate().map(|(ix, member)| {
|
||||||
let mut member = member.render(project, theme, follower_state, active_call, cx);
|
let mut flex = 1.0;
|
||||||
|
if member.contains(active_pane) {
|
||||||
|
flex = cx.global::<Settings>().active_pane_magnification;
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut member =
|
||||||
|
member.render(project, theme, follower_state, active_call, active_pane, cx);
|
||||||
if ix < last_member_ix {
|
if ix < last_member_ix {
|
||||||
let mut border = theme.workspace.pane_divider;
|
let mut border = theme.workspace.pane_divider;
|
||||||
border.left = false;
|
border.left = false;
|
||||||
|
@ -359,7 +389,7 @@ impl PaneAxis {
|
||||||
member = Container::new(member).with_border(border).boxed();
|
member = Container::new(member).with_border(border).boxed();
|
||||||
}
|
}
|
||||||
|
|
||||||
FlexItem::new(member).flex(1.0, true).boxed()
|
FlexItem::new(member).flex(flex, true).boxed()
|
||||||
}))
|
}))
|
||||||
.boxed()
|
.boxed()
|
||||||
}
|
}
|
||||||
|
|
|
@ -2670,6 +2670,7 @@ impl View for Workspace {
|
||||||
&theme,
|
&theme,
|
||||||
&self.follower_states_by_leader,
|
&self.follower_states_by_leader,
|
||||||
self.active_call(),
|
self.active_call(),
|
||||||
|
self.active_pane(),
|
||||||
cx,
|
cx,
|
||||||
))
|
))
|
||||||
.flex(1., true)
|
.flex(1., true)
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue