Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove redundant autoscroll_horizontally during editor prepaint (#34218)

Browse source 
* Experimentally `scroll_manager.anchor()` appears to be the same before
and after this 2nd call of `autoscroll_horizontally`

* Nothing these depend on seem to be mutated between the calls (and
since this is prepaint, stuff within editor also shouldn't be mutated)

Release Notes:

- N/A

Co-authored-by: Finn <finn@zed.dev>
This commit is contained in:
Michael Sloan 2025-07-10 11:03:34 -06:00 • committed by GitHub
parent e6c41b577b
commit e2e529bd94
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

23
crates/editor/src/element.rs
View file

@ -8614,29 +8614,6 @@ impl Element for EditorElement {
cx,
);
self.editor.update(cx, |editor, cx| {
let clamped = editor.scroll_manager.clamp_scroll_left(scroll_max.x);
let autoscrolled = if autoscroll_horizontally {
editor.autoscroll_horizontally(
start_row,
editor_content_width,
scroll_width,
em_advance,
&line_layouts,
window,
cx,
)
} else {
false
};
if clamped || autoscrolled {
snapshot = editor.snapshot(window, cx);
scroll_position = snapshot.scroll_position();
}
});
let line_elements = self.prepaint_lines(
start_row,
&mut line_layouts,