title_bar: Remove dependency on extensions_ui (#20929)

This PR removes a dependency on the `extensions_ui` from the `title_bar`
crate.

This dependency only existed to reference the `Extensions` action, which
has now been moved to the `zed_actions` crate.

This allows `title_bar` to move up in the crate dependency graph.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-11-20 16:05:43 -05:00 committed by GitHub
parent e0761db62d
commit e31f44450e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 9 additions and 10 deletions

3
Cargo.lock generated
View file

@ -4218,6 +4218,7 @@ dependencies = [
"vim", "vim",
"wasmtime-wasi", "wasmtime-wasi",
"workspace", "workspace",
"zed_actions",
] ]
[[package]] [[package]]
@ -12575,7 +12576,6 @@ dependencies = [
"collections", "collections",
"command_palette", "command_palette",
"editor", "editor",
"extensions_ui",
"feature_flags", "feature_flags",
"feedback", "feedback",
"gpui", "gpui",
@ -14358,7 +14358,6 @@ dependencies = [
"client", "client",
"db", "db",
"editor", "editor",
"extensions_ui",
"fuzzy", "fuzzy",
"gpui", "gpui",
"inline_completion_button", "inline_completion_button",

View file

@ -44,6 +44,7 @@ util.workspace = true
vim.workspace = true vim.workspace = true
wasmtime-wasi.workspace = true wasmtime-wasi.workspace = true
workspace.workspace = true workspace.workspace = true
zed_actions.workspace = true
[dev-dependencies] [dev-dependencies]
editor = { workspace = true, features = ["test-support"] } editor = { workspace = true, features = ["test-support"] }

View file

@ -38,12 +38,12 @@ use crate::extension_version_selector::{
ExtensionVersionSelector, ExtensionVersionSelectorDelegate, ExtensionVersionSelector, ExtensionVersionSelectorDelegate,
}; };
actions!(zed, [Extensions, InstallDevExtension]); actions!(zed, [InstallDevExtension]);
pub fn init(cx: &mut AppContext) { pub fn init(cx: &mut AppContext) {
cx.observe_new_views(move |workspace: &mut Workspace, cx| { cx.observe_new_views(move |workspace: &mut Workspace, cx| {
workspace workspace
.register_action(move |workspace, _: &Extensions, cx| { .register_action(move |workspace, _: &zed_actions::Extensions, cx| {
let existing = workspace let existing = workspace
.active_pane() .active_pane()
.read(cx) .read(cx)

View file

@ -32,7 +32,6 @@ auto_update.workspace = true
call.workspace = true call.workspace = true
client.workspace = true client.workspace = true
command_palette.workspace = true command_palette.workspace = true
extensions_ui.workspace = true
feedback.workspace = true feedback.workspace = true
feature_flags.workspace = true feature_flags.workspace = true
gpui.workspace = true gpui.workspace = true

View file

@ -581,7 +581,7 @@ impl TitleBar {
.action("Settings", zed_actions::OpenSettings.boxed_clone()) .action("Settings", zed_actions::OpenSettings.boxed_clone())
.action("Key Bindings", Box::new(zed_actions::OpenKeymap)) .action("Key Bindings", Box::new(zed_actions::OpenKeymap))
.action("Themes…", theme_selector::Toggle::default().boxed_clone()) .action("Themes…", theme_selector::Toggle::default().boxed_clone())
.action("Extensions", extensions_ui::Extensions.boxed_clone()) .action("Extensions", zed_actions::Extensions.boxed_clone())
.separator() .separator()
.link( .link(
"Book Onboarding", "Book Onboarding",
@ -617,7 +617,7 @@ impl TitleBar {
menu.action("Settings", zed_actions::OpenSettings.boxed_clone()) menu.action("Settings", zed_actions::OpenSettings.boxed_clone())
.action("Key Bindings", Box::new(zed_actions::OpenKeymap)) .action("Key Bindings", Box::new(zed_actions::OpenKeymap))
.action("Themes…", theme_selector::Toggle::default().boxed_clone()) .action("Themes…", theme_selector::Toggle::default().boxed_clone())
.action("Extensions", extensions_ui::Extensions.boxed_clone()) .action("Extensions", zed_actions::Extensions.boxed_clone())
.separator() .separator()
.link( .link(
"Book Onboarding", "Book Onboarding",

View file

@ -18,7 +18,6 @@ test-support = []
anyhow.workspace = true anyhow.workspace = true
client.workspace = true client.workspace = true
db.workspace = true db.workspace = true
extensions_ui.workspace = true
fuzzy.workspace = true fuzzy.workspace = true
gpui.workspace = true gpui.workspace = true
inline_completion_button.workspace = true inline_completion_button.workspace = true

View file

@ -250,7 +250,7 @@ impl Render for WelcomePage {
"welcome page: open extensions".to_string(), "welcome page: open extensions".to_string(),
); );
cx.dispatch_action(Box::new( cx.dispatch_action(Box::new(
extensions_ui::Extensions, zed_actions::Extensions,
)); ));
})), })),
) )

View file

@ -32,7 +32,7 @@ pub fn app_menus() -> Vec<Menu> {
items: vec![], items: vec![],
}), }),
MenuItem::separator(), MenuItem::separator(),
MenuItem::action("Extensions", extensions_ui::Extensions), MenuItem::action("Extensions", zed_actions::Extensions),
MenuItem::action("Install CLI", install_cli::Install), MenuItem::action("Install CLI", install_cli::Install),
MenuItem::separator(), MenuItem::separator(),
MenuItem::action("Hide Zed", super::Hide), MenuItem::action("Hide Zed", super::Hide),

View file

@ -32,6 +32,7 @@ actions!(
Quit, Quit,
OpenKeymap, OpenKeymap,
About, About,
Extensions,
OpenLicenses, OpenLicenses,
OpenTelemetryLog, OpenTelemetryLog,
DecreaseBufferFontSize, DecreaseBufferFontSize,