From e3ce0618a3a9a55b6a1b55118e48c9d6a087f0e2 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Fri, 27 Jun 2025 09:40:50 -0400 Subject: [PATCH] collab: Lookup avatars by GitHub ID instead of username (#33523) Closes: https://github.com/zed-industries/zed/issues/19207 This will correctly show Avatars for recently renamed/deleted users and for enterprise users where the username avatar url triggers a redirect to an auth prompt. Also saves a request (302 redirect) per avatar. Tested locally and avatars loaded as expected. Release Notes: - N/A --- crates/collab/src/db/queries/channels.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/collab/src/db/queries/channels.rs b/crates/collab/src/db/queries/channels.rs index a4899f408d..9a370bb73b 100644 --- a/crates/collab/src/db/queries/channels.rs +++ b/crates/collab/src/db/queries/channels.rs @@ -734,8 +734,8 @@ impl Database { users.push(proto::User { id: user.id.to_proto(), avatar_url: format!( - "https://github.com/{}.png?size=128", - user.github_login + "https://avatars.githubusercontent.com/u/{}?s=128&v=4", + user.github_user_id ), github_login: user.github_login, name: user.name,