From e662bfc74f85f3f4069012777b0c05063dd9512e Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Mon, 12 Aug 2024 22:11:36 -0400 Subject: [PATCH] Configure squawk rules (#16144) This PR configures [`squawk`](https://squawkhq.com/) to match our database conventions. Release Notes: - N/A --- script/lib/squawk.toml | 6 ++++++ script/squawk | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/script/lib/squawk.toml b/script/lib/squawk.toml index 1090e38286..824b8b8793 100644 --- a/script/lib/squawk.toml +++ b/script/lib/squawk.toml @@ -1,4 +1,10 @@ excluded_rules = [ + # We use `serial` already, no point changing now. + "prefer-identity", + + # We store timestamps in UTC, so we don't care about the timezone. + "prefer-timestamptz", + "prefer-big-int", "prefer-bigint-over-int", ] diff --git a/script/squawk b/script/squawk index d310795fd9..8489206f14 100755 --- a/script/squawk +++ b/script/squawk @@ -28,7 +28,7 @@ if [ -n "$SQUAWK_GITHUB_TOKEN" ]; then export SQUAWK_GITHUB_REPO_NAME=$(echo $GITHUB_REPOSITORY | awk -F/ '{print $2}') export SQUAWK_GITHUB_PR_NUMBER=$(echo $GITHUB_REF | awk 'BEGIN { FS = "/" } ; { print $3 }') - $SQUAWK_BIN $SQUAWK_ARGS upload-to-github $(git diff --name-only origin/$GITHUB_BASE_REF...origin/$GITHUB_HEAD_REF 'crates/collab/migrations/*.sql') + $SQUAWK_BIN $SQUAWK_ARGS upload-to-github $(git diff --name-only origin/$GITHUB_BASE_REF...origin/$GITHUB_HEAD_REF 'crates/collab/migrations/*.sql' 'crates/collab/migrations_llm/*.sql') else - $SQUAWK_BIN $SQUAWK_ARGS $(git ls-files --others crates/collab/migrations/*.sql) $(git diff --name-only main crates/collab/migrations/*.sql) + $SQUAWK_BIN $SQUAWK_ARGS $(git ls-files --others crates/collab/migrations/*.sql crates/collab/migrations_llm/*.sql) $(git diff --name-only main crates/collab/migrations/*.sql crates/collab/migrations_llm/*.sql) fi