chore: Fix several style lints (#17488)

It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.

Release Notes:

- N/A

crates/extensions_ui/src/extension_suggest.rs

@@ -77,11 +77,11 @@ fn suggested_extensions() -> &'static HashMap<&'static str, Arc<str>> {
     static SUGGESTIONS_BY_PATH_SUFFIX: OnceLock<HashMap<&str, Arc<str>>> = OnceLock::new();
     SUGGESTIONS_BY_PATH_SUFFIX.get_or_init(|| {
         SUGGESTIONS_BY_EXTENSION_ID
-            .into_iter()
+            .iter()
             .flat_map(|(name, path_suffixes)| {
                 let name = Arc::<str>::from(*name);
                 path_suffixes
-                    .into_iter()
+                    .iter()
                     .map(move |suffix| (*suffix, name.clone()))
             })
             .collect()

crates/extensions_ui/src/extensions_ui.rs

@@ -95,11 +95,10 @@ pub fn init(cx: &mut AppContext) {
                     .detach();
             });
 
-        cx.subscribe(workspace.project(), |_, _, event, cx| match event {
-            project::Event::LanguageNotFound(buffer) => {
+        cx.subscribe(workspace.project(), |_, _, event, cx| {
+            if let project::Event::LanguageNotFound(buffer) = event {
                 extension_suggest::suggest(buffer.clone(), cx);
             }
-            _ => {}
         })
         .detach();
     })
@@ -642,7 +641,7 @@ impl ExtensionsPage {
             context_menu.entry(
                 "Install Another Version...",
                 None,
-                cx.handler_for(&this, move |this, cx| {
+                cx.handler_for(this, move |this, cx| {
                     this.show_extension_version_list(extension_id.clone(), cx)
                 }),
             )
@@ -692,8 +691,7 @@ impl ExtensionsPage {
         has_dev_extension: bool,
         cx: &mut ViewContext<Self>,
     ) -> (Button, Option<Button>) {
-        let is_compatible =
-            extension::is_version_compatible(ReleaseChannel::global(cx), &extension);
+        let is_compatible = extension::is_version_compatible(ReleaseChannel::global(cx), extension);
 
         if has_dev_extension {
             // If we have a dev extension for the given extension, just treat it as uninstalled.
@@ -833,7 +831,7 @@ impl ExtensionsPage {
         };
 
         EditorElement::new(
-            &editor,
+            editor,
             EditorStyle {
                 background: cx.theme().colors().editor_background,
                 local_player: cx.theme().players().local(),
@@ -869,7 +867,7 @@ impl ExtensionsPage {
             // If the search was just cleared then we can just reload the list
             // of extensions without a debounce, which allows us to avoid seeing
             // an intermittent flash of a "no extensions" state.
-            if let Some(_) = search {
+            if search.is_some() {
                 cx.background_executor()
                     .timer(Duration::from_millis(250))
                     .await;
@@ -965,7 +963,7 @@ impl ExtensionsPage {
             {
                 self.upsells.insert(*feature);
             } else {
-                self.upsells.remove(&feature);
+                self.upsells.remove(feature);
             }
         }
     }