chore: Fix several style lints (#17488)

It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.

Release Notes:

- N/A

crates/markdown/examples/markdown.rs

@@ -9,7 +9,7 @@ use theme::LoadThemes;
 use ui::prelude::*;
 use ui::{div, WindowContext};
 
-const MARKDOWN_EXAMPLE: &'static str = r#"
+const MARKDOWN_EXAMPLE: &str = r#"
 # Markdown Example Document
 
 ## Headings

crates/markdown/examples/markdown_as_child.rs

@@ -9,7 +9,7 @@ use theme::LoadThemes;
 use ui::div;
 use ui::prelude::*;
 
-const MARKDOWN_EXAMPLE: &'static str = r#"
+const MARKDOWN_EXAMPLE: &str = r#"
 this text should be selectable
 
 wow so cool

crates/markdown/src/markdown.rs

@@ -260,7 +260,7 @@ impl ParsedMarkdown {
     }
 
     pub fn events(&self) -> &Arc<[(Range<usize>, MarkdownEvent)]> {
-        return &self.events;
+        &self.events
     }
 }
 
@@ -473,17 +473,15 @@ impl MarkdownElement {
                             cx.open_url(&pressed_link.destination_url);
                         }
                     }
-                } else {
-                    if markdown.selection.pending {
-                        markdown.selection.pending = false;
-                        #[cfg(target_os = "linux")]
-                        {
-                            let text = rendered_text
-                                .text_for_range(markdown.selection.start..markdown.selection.end);
-                            cx.write_to_primary(ClipboardItem::new_string(text))
-                        }
-                        cx.notify();
+                } else if markdown.selection.pending {
+                    markdown.selection.pending = false;
+                    #[cfg(target_os = "linux")]
+                    {
+                        let text = rendered_text
+                            .text_for_range(markdown.selection.start..markdown.selection.end);
+                        cx.write_to_primary(ClipboardItem::new_string(text))
                     }
+                    cx.notify();
                 }
             }
         });

crates/markdown/src/parser.rs

@@ -97,7 +97,7 @@ pub fn parse_links_only(text: &str) -> Vec<(Range<usize>, MarkdownEvent)> {
         start: 0,
         end: text.len(),
     };
-    for link in finder.links(&text) {
+    for link in finder.links(text) {
         let link_range = link.start()..link.end();
 
         if link_range.start > text_range.start {