chore: Fix several style lints (#17488)

It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.

Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz 2024-09-06 11:58:39 +02:00 committed by GitHub
parent 93249fc82b
commit e6c1c51b37
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
361 changed files with 3530 additions and 3587 deletions

View file

@ -110,6 +110,12 @@ pub struct ParsedMarkdownTableRow {
pub children: Vec<ParsedMarkdownText>,
}
impl Default for ParsedMarkdownTableRow {
fn default() -> Self {
Self::new()
}
}
impl ParsedMarkdownTableRow {
pub fn new() -> Self {
Self {

View file

@ -90,9 +90,9 @@ impl<'a> MarkdownParser<'a> {
| Event::Start(Tag::Strong)
| Event::Start(Tag::Strikethrough)
| Event::Start(Tag::Image { link_type: _, dest_url: _, title: _, id: _ }) => {
return true;
true
}
_ => return false,
_ => false,
}
}
@ -252,7 +252,7 @@ impl<'a> MarkdownParser<'a> {
let mut finder = linkify::LinkFinder::new();
finder.kinds(&[linkify::LinkKind::Url]);
let mut last_link_len = prev_len;
for link in finder.links(&t) {
for link in finder.links(t) {
let start = link.start();
let end = link.end();
let range = (prev_len + start)..(prev_len + end);
@ -415,10 +415,7 @@ impl<'a> MarkdownParser<'a> {
let mut body = vec![];
let mut current_row = vec![];
let mut in_header = true;
let column_alignments = alignment
.iter()
.map(|a| Self::convert_alignment(a))
.collect();
let column_alignments = alignment.iter().map(Self::convert_alignment).collect();
loop {
if self.eof() {
@ -440,7 +437,7 @@ impl<'a> MarkdownParser<'a> {
}
Event::End(TagEnd::TableHead) | Event::End(TagEnd::TableRow) => {
self.cursor += 1;
let new_row = std::mem::replace(&mut current_row, vec![]);
let new_row = std::mem::take(&mut current_row);
if in_header {
header.children = new_row;
in_header = false;
@ -683,7 +680,7 @@ impl<'a> MarkdownParser<'a> {
let (current, _source_range) = self.current().unwrap();
match current {
Event::Text(text) => {
code.push_str(&text);
code.push_str(text);
self.cursor += 1;
}
Event::End(TagEnd::CodeBlock) => {

View file

@ -113,7 +113,7 @@ pub fn render_parsed_markdown(
elements.push(render_markdown_block(child, &mut cx));
}
return elements;
elements
}
pub fn render_markdown_block(block: &ParsedMarkdownElement, cx: &mut RenderContext) -> AnyElement {