Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: Fix several style lints (#17488)

Browse source 
It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.

Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz 2024-09-06 11:58:39 +02:00 • committed by GitHub
parent 93249fc82b
commit e6c1c51b37
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
361 changed files with 3530 additions and 3587 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/node_runtime/src/node_runtime.rs
View file

@ -72,7 +72,7 @@ pub trait NodeRuntime: Send + Sync {
async fn npm_package_installed_version(
&self,
local_package_directory: &PathBuf,
local_package_directory: &Path,
name: &str,
) -> Result<Option<String>>;
@ -80,7 +80,7 @@ pub trait NodeRuntime: Send + Sync {
&self,
package_name: &str,
local_executable_path: &Path,
local_package_directory: &PathBuf,
local_package_directory: &Path,
latest_version: &str,
) -> bool {
// In the case of the local system not having the package installed,
@ -102,7 +102,7 @@ pub trait NodeRuntime: Send + Sync {
let Some(installed_version) = Version::parse(&installed_version).log_err() else {
return true;
};
let Some(latest_version) = Version::parse(&latest_version).log_err() else {
let Some(latest_version) = Version::parse(latest_version).log_err() else {
return true;
};
@ -360,10 +360,10 @@ impl NodeRuntime for RealNodeRuntime {
async fn npm_package_installed_version(
&self,
local_package_directory: &PathBuf,
local_package_directory: &Path,
name: &str,
) -> Result<Option<String>> {
let mut package_json_path = local_package_directory.clone();
let mut package_json_path = local_package_directory.to_owned();
package_json_path.extend(["node_modules", name, "package.json"]);
let mut file = match fs::File::open(package_json_path).await {
@ -394,7 +394,7 @@ impl NodeRuntime for RealNodeRuntime {
packages: &[(&str, &str)],
) -> Result<()> {
let packages: Vec<_> = packages
.into_iter()
.iter()
.map(|(name, version)| format!("{name}@{version}"))
.collect();
@ -448,7 +448,7 @@ impl NodeRuntime for FakeNodeRuntime {
async fn npm_package_installed_version(
&self,
_local_package_directory: &PathBuf,
_local_package_directory: &Path,
name: &str,
) -> Result<Option<String>> {
unreachable!("Should not query npm package '{name}' for installed version")