chore: Fix several style lints (#17488)

It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.

Release Notes:

- N/A

crates/semantic_index/src/chunking.rs

@@ -51,7 +51,7 @@ fn syntactic_ranges(
     let outline = grammar.outline_config.as_ref()?;
     let tree = with_parser(|parser| {
         parser.set_language(&grammar.ts_language).log_err()?;
-        parser.parse(&text, None)
+        parser.parse(text, None)
     });
 
     let Some(tree) = tree else {

crates/semantic_index/src/embedding/ollama.rs

@@ -41,7 +41,7 @@ impl EmbeddingProvider for OllamaEmbeddingProvider {
             OllamaEmbeddingModel::MxbaiEmbedLarge => "mxbai-embed-large",
         };
 
-        futures::future::try_join_all(texts.into_iter().map(|to_embed| {
+        futures::future::try_join_all(texts.iter().map(|to_embed| {
             let request = OllamaEmbeddingRequest {
                 model: model.to_string(),
                 prompt: to_embed.text.to_string(),

crates/semantic_index/src/semantic_index.rs

@@ -1047,7 +1047,7 @@ mod tests {
     use std::{future, path::Path, sync::Arc};
 
     fn init_test(cx: &mut TestAppContext) {
-        _ = cx.update(|cx| {
+        cx.update(|cx| {
             let store = SettingsStore::test(cx);
             cx.set_global(store);
             language::init(cx);
@@ -1068,10 +1068,10 @@ mod tests {
             batch_size: usize,
             compute_embedding: impl 'static + Fn(&str) -> Result<Embedding> + Send + Sync,
         ) -> Self {
-            return Self {
+            Self {
                 batch_size,
                 compute_embedding: Box::new(compute_embedding),
-            };
+            }
         }
     }