Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant2: Avoid unnecessary String cloning in tool use (#25725)

Browse source 
This PR removes some unnecessary `String` cloning in the tool use paths.

We now store the data in `Arc<str>`s for cheap cloning.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2025-02-26 22:16:09 -05:00 • committed by GitHub
parent da22f21dec
commit e7df5ce61c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 19 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/language_models/src/provider/anthropic.rs
View file

@ -506,7 +506,7 @@ pub fn into_anthropic(
MessageContent::ToolUse(tool_use) => {
Some(anthropic::RequestContent::ToolUse {
id: tool_use.id.to_string(),
name: tool_use.name,
name: tool_use.name.to_string(),
input: tool_use.input,
cache_control,
})
@ -515,7 +515,7 @@ pub fn into_anthropic(
Some(anthropic::RequestContent::ToolResult {
tool_use_id: tool_result.tool_use_id.to_string(),
is_error: tool_result.is_error,
content: tool_result.content,
content: tool_result.content.to_string(),
cache_control,
})
}
@ -636,7 +636,7 @@ pub fn map_to_language_model_completion_events(
Ok(LanguageModelCompletionEvent::ToolUse(
LanguageModelToolUse {
id: tool_use.id.into(),
name: tool_use.name,
name: tool_use.name.into(),
input: if tool_use.input_json.is_empty() {
serde_json::Value::Null
} else {

2
crates/language_models/src/provider/bedrock.rs
View file

@ -731,7 +731,7 @@ pub fn map_to_language_model_completion_events(
Ok(LanguageModelCompletionEvent::ToolUse(
LanguageModelToolUse {
id: tool_use.id.into(),
name: tool_use.name,
name: tool_use.name.into(),
input: if tool_use.input_json.is_empty()
{
Value::Null