From e95e1c9ae5bd94ffaa595b8e56a727802441457d Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Mon, 23 Sep 2024 19:45:00 +0000 Subject: [PATCH] Add '?plain=1' to Permalinks on GitLab/GitHub for md files (#18241) Improve our Permalinks to markdown files. GitHub/GitLab supports the same URL syntax. --- crates/git_hosting_providers/src/providers/github.rs | 3 +++ crates/git_hosting_providers/src/providers/gitlab.rs | 3 +++ 2 files changed, 6 insertions(+) diff --git a/crates/git_hosting_providers/src/providers/github.rs b/crates/git_hosting_providers/src/providers/github.rs index be46b51ddf..77eaa80961 100644 --- a/crates/git_hosting_providers/src/providers/github.rs +++ b/crates/git_hosting_providers/src/providers/github.rs @@ -145,6 +145,9 @@ impl GitHostingProvider for Github { .base_url() .join(&format!("{owner}/{repo}/blob/{sha}/{path}")) .unwrap(); + if path.ends_with(".md") { + permalink.set_query(Some("plain=1")); + } permalink.set_fragment( selection .map(|selection| self.line_fragment(&selection)) diff --git a/crates/git_hosting_providers/src/providers/gitlab.rs b/crates/git_hosting_providers/src/providers/gitlab.rs index ccb8a7280a..36ee214cf9 100644 --- a/crates/git_hosting_providers/src/providers/gitlab.rs +++ b/crates/git_hosting_providers/src/providers/gitlab.rs @@ -65,6 +65,9 @@ impl GitHostingProvider for Gitlab { .base_url() .join(&format!("{owner}/{repo}/-/blob/{sha}/{path}")) .unwrap(); + if path.ends_with(".md") { + permalink.set_query(Some("plain=1")); + } permalink.set_fragment( selection .map(|selection| self.line_fragment(&selection))