Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make danger to output less false-positives (#19151)

Browse source
This commit is contained in:
Kirill Bulatov 2024-10-14 01:50:46 +03:00 • committed by GitHub
parent 54683ff2b9
commit ec5d6e96bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
script/danger/dangerfile.ts
View file

@ -37,10 +37,11 @@ if (!hasReleaseNotes) {
} }
const ISSUE_LINK_PATTERN = new RegExp( const ISSUE_LINK_PATTERN = new RegExp(
"https://github\\.com/[\\w-]+/[\\w-]+/issues/\\d+", "(?<!(?:Close[sd]?|Fixe[sd]|Resolve[sd]|Implement[sed])\\s+)https://github\\.com/[\\w-]+/[\\w-]+/issues/\\d+",
"g", "gi"
); );
const includesIssueUrl = ISSUE_LINK_PATTERN.test(body); const includesIssueUrl = ISSUE_LINK_PATTERN.test(body);
if (includesIssueUrl) { if (includesIssueUrl) {

18
typos.toml
View file

@ -7,7 +7,7 @@ extend-exclude = [
# Contributor names aren't typos. # Contributor names aren't typos.
".mailmap", ".mailmap",
# File suffixes aren't typos # File suffixes aren't typos.
"assets/icons/file_icons/file_types.json", "assets/icons/file_icons/file_types.json",
"crates/extensions_ui/src/extension_suggest.rs", "crates/extensions_ui/src/extension_suggest.rs",
@ -21,26 +21,28 @@ extend-exclude = [
# Stripe IDs are flagged as typos. # Stripe IDs are flagged as typos.
"crates/collab/src/db/tests/processed_stripe_event_tests.rs", "crates/collab/src/db/tests/processed_stripe_event_tests.rs",
# Not our typos # Not our typos.
"crates/live_kit_server/", "crates/live_kit_server/",
# Vim makes heavy use of partial typing tables # Vim makes heavy use of partial typing tables.
"crates/vim/", "crates/vim/",
# Editor and file finder rely on partial typing and custom in-string syntax # Editor and file finder rely on partial typing and custom in-string syntax.
"crates/file_finder/src/file_finder_tests.rs", "crates/file_finder/src/file_finder_tests.rs",
"crates/editor/src/editor_tests.rs", "crates/editor/src/editor_tests.rs",
# Clojure uses .edn filename extension, which is not a misspelling of "end" # Clojure uses .edn filename extension, which is not a misspelling of "end".
"extensions/clojure/languages/clojure/config.toml", "extensions/clojure/languages/clojure/config.toml",
# There are some names in the test data that are incorrectly flagged as typos. # There are some names in the test data that are incorrectly flagged as typos.
"crates/git/test_data/blame_incremental_complex", "crates/git/test_data/blame_incremental_complex",
"crates/git/test_data/golden/blame_incremental_complex.json", "crates/git/test_data/golden/blame_incremental_complex.json",
# We have some base64-encoded data that is incorrectly being flagged. # We have some base64-encoded data that is incorrectly being flagged.
"crates/rpc/src/auth.rs", "crates/rpc/src/auth.rs",
# glsl isn't recognized by this tool # glsl isn't recognized by this tool.
"extensions/glsl/languages/glsl/", "extensions/glsl/languages/glsl/",
# Windows likes its abbreviations # Windows likes its abbreviations.
"crates/gpui/src/platform/windows/", "crates/gpui/src/platform/windows/",
# Some typos in the base mdBook CSS. # Some typos in the base mdBook CSS.
"docs/theme/css/" "docs/theme/css/",
# Spellcheck triggers on `|Fixe[sd]|` regex part.
"script/danger/dangerfile.ts",
] ]
[default] [default]