From ed510b5e937e893f99b432caa2f887233f44251e Mon Sep 17 00:00:00 2001
From: "Joseph T. Lyons" <JosephTLyons@gmail.com>
Date: Tue, 18 Mar 2025 16:39:54 -0400
Subject: [PATCH] Remove unused AssistantThreadFeedback event (#27021)

It looks like:

- https://github.com/zed-industries/zed/pull/26780

accidentally added a new event type, `AssistantThreadFeedback`, using
the old event system, that it didn't end up actually using, as the code
actually relies on using the newer (preferred) `telemetry::event!()`.

Release Notes:

- N/A
---
 crates/collab/src/api/events.rs               |  4 ----
 .../telemetry_events/src/telemetry_events.rs  | 21 -------------------
 2 files changed, 25 deletions(-)

diff --git a/crates/collab/src/api/events.rs b/crates/collab/src/api/events.rs
index 3d9faab529..c7792690f8 100644
--- a/crates/collab/src/api/events.rs
+++ b/crates/collab/src/api/events.rs
@@ -660,10 +660,6 @@ fn for_snowflake(
                 e.event_type.clone(),
                 serde_json::to_value(&e.event_properties).unwrap(),
             ),
-            Event::AssistantThreadFeedback(e) => (
-                "Assistant Feedback".to_string(),
-                serde_json::to_value(&e).unwrap(),
-            ),
         };
 
         if let serde_json::Value::Object(ref mut map) = event_properties {
diff --git a/crates/telemetry_events/src/telemetry_events.rs b/crates/telemetry_events/src/telemetry_events.rs
index 29ad412874..81106b89da 100644
--- a/crates/telemetry_events/src/telemetry_events.rs
+++ b/crates/telemetry_events/src/telemetry_events.rs
@@ -97,7 +97,6 @@ pub enum Event {
     InlineCompletionRating(InlineCompletionRatingEvent),
     Call(CallEvent),
     Assistant(AssistantEvent),
-    AssistantThreadFeedback(AssistantThreadFeedbackEvent),
     Cpu(CpuEvent),
     Memory(MemoryEvent),
     App(AppEvent),
@@ -231,26 +230,6 @@ pub struct ReplEvent {
     pub repl_session_id: String,
 }
 
-#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-pub enum ThreadFeedbackRating {
-    Positive,
-    Negative,
-}
-
-#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
-pub struct AssistantThreadFeedbackEvent {
-    /// Unique identifier for the thread
-    pub thread_id: String,
-    /// The feedback rating (thumbs up or thumbs down)
-    pub rating: ThreadFeedbackRating,
-    /// The serialized thread data containing messages, tool calls, etc.
-    pub thread_data: serde_json::Value,
-    /// The initial project snapshot taken when the thread was created
-    pub initial_project_snapshot: serde_json::Value,
-    /// The final project snapshot taken when the thread was first saved
-    pub final_project_snapshot: serde_json::Value,
-}
-
 #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
 pub struct BacktraceFrame {
     pub ip: usize,