Avoid unnecessary DB writes (#29417)

Part of https://github.com/zed-industries/zed/issues/16472

* Adds debug logging to everywhere near INSERT/UPDATEs in the DB

So something like 
`env RUST_LOG=debug,wasmtime_cranelift=off,cranelift_codegen=off,vte=off
cargo run` could be used to view these (current zlog seems to process
the exclusions odd, so not sure this is the optimal RUST_LOG line) can
be used to debug any further writes.

* Removes excessive window stack serialization

Previously, it serialized unconditionally every 100ms.
Now, only if the stack had changed, which is now check every 500ms.

* Removes excessive terminal serialization

Previously, it serialized its `cwd` on every `ItemEvent::UpdateTab`
which was caused by e.g. any character output.
Now, only if the `cwd` has changed at the next event processing time.

Release Notes:

- Fixed more excessive DB writes
This commit is contained in:
Kirill Bulatov 2025-04-25 17:41:49 +03:00 committed by GitHub
parent 37fa437990
commit f106dfca42
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 224 additions and 168 deletions

View file

@ -1,7 +1,7 @@
use std::time::Duration;
use db::kvp::KEY_VALUE_STORE;
use gpui::{AnyWindowHandle, AppContext as _, Context, Subscription, Task, WindowId};
use gpui::{App, AppContext as _, Context, Subscription, Task, WindowId};
use util::ResultExt;
use uuid::Uuid;
@ -59,7 +59,7 @@ impl Session {
pub struct AppSession {
session: Session,
_serialization_task: Option<Task<()>>,
_serialization_task: Task<()>,
_subscriptions: Vec<Subscription>,
}
@ -67,17 +67,21 @@ impl AppSession {
pub fn new(session: Session, cx: &Context<Self>) -> Self {
let _subscriptions = vec![cx.on_app_quit(Self::app_will_quit)];
let _serialization_task = Some(cx.spawn(async move |_, cx| {
let _serialization_task = cx.spawn(async move |_, cx| {
let mut current_window_stack = Vec::new();
loop {
if let Some(windows) = cx.update(|cx| cx.window_stack()).ok().flatten() {
store_window_stack(windows).await;
if let Some(windows) = cx.update(|cx| window_stack(cx)).ok().flatten() {
if windows != current_window_stack {
store_window_stack(&windows).await;
current_window_stack = windows;
}
}
cx.background_executor()
.timer(Duration::from_millis(100))
.timer(Duration::from_millis(500))
.await;
}
}));
});
Self {
session,
@ -87,8 +91,8 @@ impl AppSession {
}
fn app_will_quit(&mut self, cx: &mut Context<Self>) -> Task<()> {
if let Some(windows) = cx.window_stack() {
cx.background_spawn(store_window_stack(windows))
if let Some(window_stack) = window_stack(cx) {
cx.background_spawn(async move { store_window_stack(&window_stack).await })
} else {
Task::ready(())
}
@ -107,13 +111,17 @@ impl AppSession {
}
}
async fn store_window_stack(windows: Vec<AnyWindowHandle>) {
let window_ids = windows
.into_iter()
.map(|window| window.window_id().as_u64())
.collect::<Vec<_>>();
fn window_stack(cx: &App) -> Option<Vec<u64>> {
Some(
cx.window_stack()?
.into_iter()
.map(|window| window.window_id().as_u64())
.collect(),
)
}
if let Ok(window_ids_json) = serde_json::to_string(&window_ids) {
async fn store_window_stack(windows: &[u64]) {
if let Ok(window_ids_json) = serde_json::to_string(windows) {
KEY_VALUE_STORE
.write_kvp(SESSION_WINDOW_STACK_KEY.to_string(), window_ids_json)
.await